Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,10 @@

- [ ] `npm ci` and `npm test` pass locally.
- [ ] Serialized files were produced or verified with native abapGit; XML was not hand-authored without a system round trip.
- [ ] Native abapGit staging contained only intended objects; unrelated system/Git drift was documented and left unselected.
- [ ] ABAP 7.50: pull, activation, syntax check, ABAP Unit, and ATC pass, or this is not applicable and is explained below.
- [ ] S/4HANA 2023: pull, activation, syntax check, ABAP Unit, and ATC pass, or this is not applicable and is explained below.
- [ ] Activation evidence covers affected child parts (screens, GUI statuses, text elements, and includes), not only main-source equality.
- [ ] A safe manual ZTOAD smoke test passes on both systems, or the omitted system/check is explained below.
- [ ] ST22 was checked before/after live smoke; known and new dumps are distinguished.
- [ ] ATC prerequisite/check errors were reviewed; an incomplete run is not reported as zero findings.
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/quality.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ concurrency:

jobs:
abaplint:
name: abaplint (ABAP 7.50)
name: Repository quality (ABAP 7.50)
runs-on: ubuntu-latest
timeout-minutes: 10
steps:
Expand All @@ -31,5 +31,5 @@ jobs:
- name: Install pinned dependencies
run: npm ci

- name: Run local ABAP checks
- name: Run ABAP and repository-contract checks
run: npm test
4 changes: 3 additions & 1 deletion AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,15 @@ For changes that affect `src/` or live behavior:
4. Write an implementation/test/rollback plan in `docs/plans/`, including ABAP 7.50 compatibility, Clean ABAP/Clean Core, abaplint, ABAP Unit, live activation/syntax/ATC, safe browser smoke, and ST22 delta. Review the plan before production changes.
5. Implement the smallest change that turns the test green. Refactor only while the complete suite remains green. For frontend, database, authorization, or other environment-dependent assumptions, treat the first green implementation as a spike until a live integration test confirms it. Edit source locally for source-only changes; create structural SAP objects in a development system and export them with native abapGit instead of inventing serializer XML.
6. Run `npm ci`, `npm test`, `git diff --check`, a complete diff review, and the relevant security/authorization review. Deploy the exact candidate to each available SAP target without pretending that the shared abapGit `master` link represents an unmerged branch.
7. On SAP_BASIS 750 first when available, then S/4HANA 2023, require controlled activation, active syntax, all ABAP Unit tests, and complete ATC runs or explicit prerequisite failures. An ARC-1 write acknowledgement or `activate=true` request is not activation evidence: call activation explicitly, then require active/inactive object-state equality. Run a fresh-session safe browser smoke and ST22 delta on A4H only. A failed/unavailable gate is never a pass.
7. On SAP_BASIS 750 first when available, then S/4HANA 2023, require controlled activation, active syntax, all ABAP Unit tests, and complete ATC runs or explicit prerequisite failures. An ARC-1 write acknowledgement or `activate=true` request is not activation evidence: call activation explicitly, require active/inactive main-object equality, and query inactive child parts (including screens, GUI statuses, text elements, and includes) for every changed composite object. Main-source equality alone is not a pass when a child part remains inactive. Run a fresh-session safe browser smoke and ST22 delta on A4H only. A failed/unavailable gate is never a pass.
8. Perform a final implementation review, update finding evidence, commit with a Conventional Commit subject, push the branch, open a pull request, and wait for required CI to become green.
9. After the first green PR run, audit the plan, implementation, test evidence, CI output, and development process. Apply useful process/documentation improvements to the same PR, move its plan to `docs/plans/finished/`, push, and wait for CI again.
10. Merge only after the maintainer accepts any recorded live-system limitations. Pull the resulting `master`, verify Release Please behavior, and do not manually tag an ordinary release.

For a source-only candidate, a controlled direct source deployment is preferable to switching the shared native-abapGit repository away from `master`. Record the candidate commit/hash and activate only the intended object. Structural changes still require a real native-abapGit round trip and may need a dedicated package/system to avoid changing shared objects underneath other work.

For a coordinated structural-object round trip, refresh native abapGit before staging, review all system/Git drift, and select only the intended object. Never use **Add All** when unrelated changes are present. Review the staged filenames before commit, record every intentionally unselected drift item, push, refresh again, and require the intended object to be clean.

If ARC-1's pre-write linter selects the wrong ABAP release, bypass only that local lint step after the repository's pinned abaplint gate is green. Keep server preflight, explicit activation, SAP syntax, Unit, ATC, and object-state verification enabled, and record the tooling mismatch in the findings register.

If ARC-1 authentication or a live system is unavailable, local checks may continue, but do not claim live validation. Record the missing gate in the PR and complete it before merge unless the maintainer explicitly accepts the risk.
Expand Down
4 changes: 2 additions & 2 deletions docs/baseline-findings.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# ZTOAD baseline findings

_Snapshot: 2026-08-06 · branch `codex/fix-base-run-001` · live system A4H client 001, SAP_BASIS 758 SP02 · secondary target NPL client 001, SAP_BASIS 750 SP02_
_Snapshot: 2026-08-06 · branch `codex/fix-base-bug-006` · live system A4H client 001, SAP_BASIS 758 SP02 · secondary target NPL client 001, SAP_BASIS 750 SP02_

This is the ordered work list for incremental TDD. It records observed defects separately from broad style debt so a new failure cannot disappear inside the legacy backlog. A finding is closed only after its regression test is green locally where possible, green on A4H, and green on the SAP_BASIS 750 target.

Expand Down Expand Up @@ -36,7 +36,7 @@ Priority meanings: **P0** blocks the requested test workflow or is an immediate
| BASE-BUG-003 | P1 | [Issue #4](https://github.com/marianfoo/ztoad/issues/4): `SUBSTRING`/`CONCAT` produce “No component exists with the name SUBSTRING(”, exposing naïve select-list tokenization. | Nested function arguments, commas inside functions, aliases, literals containing spaces/commas, and function composition. | Open |
| BASE-BUG-004 | P1 | Keyword detection uses string searches and space splitting rather than quote/parenthesis-aware lexical tokens. Keywords in literals, comments, functions, or subqueries can move clause boundaries. | Quoted `FROM`, `WHERE`, `UNION`, `UP TO`; escaped quotes; comments; nested parentheses; multiline queries. | Open |
| BASE-BUG-005 | P1 | `UNION` splitting is whitespace-sensitive and does not model `UNION ALL`; branches are appended while assuming compatible result layouts. | `UNION`, `UNION ALL`, mismatched branch types/columns, per-branch limits, and keywords in literals/subqueries. | Open |
| BASE-BUG-006 | P1 | [Issue #2](https://github.com/marianfoo/ztoad/issues/2): no serialized `TRAN ZTOAD` exists, so FLP/WebGUI cannot launch a stable ZTOAD transaction directly. | Native-abapGit round-trip on both systems plus direct FLP and standalone WebGUI launch tests. | Open |
| BASE-BUG-006 | P1 | [Issue #2](https://github.com/marianfoo/ztoad/issues/2): no serialized `TRAN ZTOAD` existed, so FLP/WebGUI could not launch a stable ZTOAD transaction directly. | Repository contract, native-abapGit round trip, direct FLP and standalone WebGUI launch, ST22 delta, and ADT-only 7.50 availability check. | Fixed candidate: local contract green; native A4H object clean; both launch paths reach ZTOAD with no new dump. Exact NPL install remains prerequisite-blocked because all ZTOAD objects are absent. |
| BASE-BUG-007 | P1 | [Issue #5](https://github.com/marianfoo/ztoad/issues/5): source-only/manual installation is incomplete. A4H currently reaches screen 0010 but reports missing GUI status `STATUS010` even though repository `ztoad.prog.xml` serializes it; complete ZTOAD also needs its dynpros, TABL, and SUSO. | Fresh-package native-abapGit install test verifying all serialized objects and GUI metadata activate, `STATUS010` exists, and the first read-only query can be dispatched. | Open; currently blocks full A4H query smoke |
| BASE-RUN-002 | P1 | Generated-program failures are not isolated into a stable error contract; dumps or generated source can leak query details. | Syntax/runtime exception tests with sanitized error output and no ST22 dump for expected bad input. | Open |
| BASE-RUN-003 | P1 | The generated subroutine-pool approach has a finite per-session pool budget and encourages session restart behavior instead of bounded execution objects. | Repeated-query stress test across the documented maximum, checking graceful handling and cleanup. | Open |
Expand Down
15 changes: 8 additions & 7 deletions docs/development.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ This is the normative workflow for future issues and features. Its goal is fast

## 1. Architecture and trust boundaries

ZTOAD is not only `src/ztoad.prog.abap`. The report also depends on its program metadata and dynpros (`ztoad.prog.xml`), persisted-query table (`ztoad.tabl.xml`), and authorization object (`ztoad_auth.suso.xml`). Future transaction codes or other repository objects will add more serialized files.
ZTOAD is not only `src/ztoad.prog.abap`. The report also depends on its program metadata and dynpros (`ztoad.prog.xml`), persisted-query table (`ztoad.tabl.xml`), authorization object (`ztoad_auth.suso.xml`), and report transaction (`ztoad.tran.xml`).

Use each tool for the part it can represent faithfully:

Expand Down Expand Up @@ -58,7 +58,7 @@ On A4H, the Fiori-shell URL for the transaction is:

`https://a4h.marianzeis.de/sap/bc/ui2/flp?sap-client=001#Shell-startGUI?sap-ui2-tcode=ZABAPGIT`

Do not manually install only the report source. That omits the dynpros, table, and authorization object and cannot reproduce a supported installation.
Do not manually install only the report source. That omits the dynpros, table, authorization object, and transaction and cannot reproduce a supported installation. The repository-managed launcher is report transaction `ZTOAD` for program `ZTOAD`; use `#Shell-startGUI?sap-ui2-tcode=ZTOAD` or standalone `~transaction=ZTOAD` for its A4H smoke test.

## 4. Local-first TDD flow with a stable `master`

Expand All @@ -70,7 +70,7 @@ Do not manually install only the report source. That omits the dynpros, table, a
4. Write and review a plan under `docs/plans/` covering implementation, ABAP 7.50, Clean ABAP/Clean Core, local/live tests, rollback, browser smoke, and ST22.
5. Edit source locally and make the smallest production change that turns the test green. For a frontend or other environment-dependent assumption, keep the candidate classified as a spike until live integration evidence accepts it. Keep serializer XML unchanged for a source-only fix.
6. Run `npm ci`, `npm test`, `git diff --check`, and the final local/security review.
7. Deploy the exact candidate source to SAP_BASIS 750 first through ARC-1/ADT when its real dependencies exist; record any missing ADT prerequisite as blocked. Keep the A4H native-abapGit link on `master` and record an unmerged candidate as a direct deployment. Follow every write with an explicit activation call and active/inactive object-state comparison; a write response or activation option alone is not proof that the active version changed.
7. Deploy the exact candidate source to SAP_BASIS 750 first through ARC-1/ADT when its real dependencies exist; record any missing ADT prerequisite as blocked. Keep the A4H native-abapGit link on `master` and record an unmerged candidate as a direct deployment. Follow every write with an explicit activation call, active/inactive main-object comparison, and an inactive-child-part query for affected composite objects; a write response, activation option, or equal main-source hash alone does not prove that screens, statuses, texts, and includes are active.
8. On NPL, activate only the intended object and run active syntax, all ABAP Unit tests, and complete ATC variants through ARC-1. On A4H/SAP_BASIS 758, repeat those checks and additionally start a fresh browser session for safe smoke and ST22 delta. Verify required dynpros/GUI statuses before attributing an end-to-end failure to the source candidate.
9. If a correction must be made in SAP, export it through native abapGit or reproduce it locally, then review every serialized/source difference. Never leave an unexported system-only fix.
10. Perform a final review, update evidence, commit/push the short-lived branch, open the PR, and wait for CI. After the first green run, audit the process/CI, update guidance in the same PR, move the plan to `docs/plans/finished/`, push, and wait again.
Expand All @@ -89,10 +89,11 @@ For these changes:

1. Create/change the object on the ABAP 7.50 development system when the object type exists there.
2. Activate and run the relevant checks.
3. Stage only the affected object in native abapGit and push it to the pull-request branch after its relevant checks are green.
4. Pull locally and inspect every generated file.
5. Run `npm test`.
6. Deploy the same pull-request candidate into 2023 and validate deserialization/activation.
3. Refresh native abapGit and review the complete diff before staging. If unrelated system/Git drift is present, record it and never use **Add All**.
4. Select only the affected object, review the staged filenames, and push it to the pull-request branch after its relevant checks are green.
5. Refresh again and require the intended object to be clean; unrelated unselected drift may remain only when it is explicitly documented.
6. Pull locally, inspect every generated file, and run `npm test`.
7. Deploy the same pull-request candidate into 2023 and validate deserialization, explicit activation, main-object state, and all affected inactive child parts.

If an object can only be created correctly on 2023, export it there first, then prove that the serialized form can be pulled and activated on 7.50 before accepting it. Do not fix serializer XML by guesswork.

Expand Down
Loading