Skip to content

fix: add ZTOAD transaction launcher - #17

Merged
marianfoo merged 5 commits into
masterfrom
codex/fix-base-bug-006
Aug 6, 2026
Merged

marianfoo merged 5 commits into
masterfrom
codex/fix-base-bug-006

Conversation

@marianfoo

@marianfoo marianfoo commented Aug 6, 2026 •

Copy link
Copy Markdown
Owner

Goal

Fixes #2 by adding a repository-managed report transaction ZTOAD that launches the existing executable report through both FLP and standalone WebGUI.

Plan and red evidence

The completed plan is in docs/plans/finished/base-bug-006.md, with supporting research in docs/research/2026-08-06-base-bug-006-transaction.md.

Before serialization, configured abaplint passed and the focused repository contract failed with: Missing native-abapGit transaction object: src/ztoad.tran.xml.

Validation

  • npm ci and npm test pass locally.
  • Serialized files were produced or verified with native abapGit; XML was not hand-authored without a system round trip.
  • Native abapGit staging contained only intended objects; unrelated system/Git drift was documented and left unselected.
  • ABAP 7.50: pull, activation, syntax check, ABAP Unit, and ATC pass, or this is not applicable and is explained below.
  • S/4HANA 2023: pull, activation, syntax check, ABAP Unit, and ATC pass, or this is not applicable and is explained below.
  • Activation evidence covers affected child parts (screens, GUI statuses, text elements, and includes), not only main-source equality.
  • A safe manual ZTOAD smoke test passes on both systems, or the omitted system/check is explained below.
  • ST22 was checked before/after live smoke; known and new dumps are distinguished.
  • ATC prerequisite/check errors were reviewed; an incomplete run is not reported as zero findings.
  • Authorization and SQL-injection implications were reviewed.
  • New or changed logic has ABAP Unit coverage where technically feasible.
  • Documentation and changelog impact were considered.

Test evidence / exceptions

  • Local: npm ci reports 0 vulnerabilities; npm test reports 0 configured abaplint issues and the repository contract passes. Diagnostic lint remains at the explained 1,878-finding/58-rule candidate baseline.
  • Native abapGit: serialized only TRAN ZTOAD; a follow-up stage shows the transaction clean. Unrelated A4H program/table/package drift was recorded and left unselected.
  • A4H / SAP_BASIS 758: active syntax 0 errors and 4 known warnings; ABAP Unit 19/19; ABAP_CLOUD_READINESS 768 findings; S4HANA_READINESS_2023 returned no rows but is explicitly non-authoritative because prerequisites are unavailable.
  • A4H activation: main-source hashes are identical after explicit activation, but ARC-1 still lists program screens/text parts as inactive. That existing installation drift is not hidden as a pass and remains associated with BASE-BUG-007; this transaction PR includes no unrelated program metadata.
  • A4H runtime: direct standalone WebGUI and FLP Shell-startGUI both reach the ZTOAD editor. Pre/post ST22 lists are identical. Missing STATUS010 remains the independent BASE-BUG-007 blocker.
  • NPL / SAP_BASIS 750: ADT-only connection and exact search succeed, but all ZTOAD objects are absent. The table cannot be created over the available ADT surface and TRAN cannot be native-round-tripped there, so exact install/activation/syntax/Unit/ATC is prerequisite-blocked. No FLP, WebGUI, SAP GUI, or browser automation was used.
  • Security: this adds only the normal S_TCODE start gate; it changes no SQL construction or execution logic.

Final review and process audit

  • First green: head fe46f14, GitHub Quality run 31097535470, plus both external abaplint checks.
  • Audit finding 1: main-source equality can coexist with inactive screens/text/status parts. AGENTS.md, development guidance, test strategy, and the PR checklist now require child-part activation review.
  • Audit finding 2: native abapGit exposed unrelated shared-system drift. The workflow now requires selective staging, staged-file review, post-push refresh, and prohibits Add All when unrelated drift exists.
  • Audit finding 3: the GitHub job label described only abaplint even though npm test also runs the structural repository contract. It is now named Repository quality (ABAP 7.50).
  • Final workflow green: head 7f36b64, GitHub Quality run 31097691676, plus both external abaplint checks.\n- Finished-plan closeout: final head b395aaf passed GitHub Quality run 31097843601 plus both external abaplint checks.
  • Final branch review: clean working tree, no whitespace errors, 12 intentional files, GitHub merge state CLEAN.

Release note

Add transaction code ZTOAD for direct report startup in SAP GUI for Windows and WebGUI.

@marianfoo
marianfoo marked this pull request as ready for review August 6, 2026 12:17
@marianfoo
marianfoo merged commit a907835 into master Aug 6, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Transaction code

1 participant