Repository navigation
fix: add ZTOAD transaction launcher - #17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Fixes #2 by adding a repository-managed report transaction
ZTOADthat launches the existing executable report through both FLP and standalone WebGUI.Plan and red evidence
The completed plan is in docs/plans/finished/base-bug-006.md, with supporting research in docs/research/2026-08-06-base-bug-006-transaction.md.
Before serialization, configured abaplint passed and the focused repository contract failed with:
Missing native-abapGit transaction object: src/ztoad.tran.xml.Validation
npm ciandnpm testpass locally.Test evidence / exceptions
npm cireports 0 vulnerabilities;npm testreports 0 configured abaplint issues and the repository contract passes. Diagnostic lint remains at the explained 1,878-finding/58-rule candidate baseline.TRAN ZTOAD; a follow-up stage shows the transaction clean. Unrelated A4H program/table/package drift was recorded and left unselected.ABAP_CLOUD_READINESS768 findings;S4HANA_READINESS_2023returned no rows but is explicitly non-authoritative because prerequisites are unavailable.Shell-startGUIboth reach the ZTOAD editor. Pre/post ST22 lists are identical. MissingSTATUS010remains the independent BASE-BUG-007 blocker.TRANcannot be native-round-tripped there, so exact install/activation/syntax/Unit/ATC is prerequisite-blocked. No FLP, WebGUI, SAP GUI, or browser automation was used.S_TCODEstart gate; it changes no SQL construction or execution logic.Final review and process audit
fe46f14, GitHub Quality run 31097535470, plus both external abaplint checks.npm testalso runs the structural repository contract. It is now namedRepository quality (ABAP 7.50).7f36b64, GitHub Quality run 31097691676, plus both external abaplint checks.\n- Finished-plan closeout: final headb395aafpassed GitHub Quality run 31097843601 plus both external abaplint checks.CLEAN.Release note
Add transaction code
ZTOADfor direct report startup in SAP GUI for Windows and WebGUI.