Update Unit Tests in PolarizationEffiency Cor #38458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
yusufjimoh
added
ISIS Team: LSS
rbauststfc
reviewed
Dec 10, 2024
- wrote unit tests to check that wildes method perform well when spinstates is added - wrote unit tests to check that fredrik method throws exception when tested with wildes-only properties spinstates and flippers - wrote unit tests to check that fredrikze method can take AddSpinStateToLog property - refactored unit tests for maintainability
yusufjimoh
force-pushed
the
38287-maintenance-tasks-for-polarizationefficiencycor
branch
from
4b77f47 to
9aec5e6
Compare
rbauststfc
reviewed
Dec 13, 2024
- created efficiency output workspace method to cater for duplication in createEfficiencyWorkspace - moved functions from setAlgorithmProperties to createAlgorithm method
rbauststfc
reviewed
Dec 18, 2024
| } | ||
|
|
||
| MatrixWorkspace_sptr createEfficiencyOutputWorkspace(size_t size = 10, double endX = 10) { | ||
| auto ws1 = createPointWS(size, 0, endX); |
There was a problem hiding this comment.
I think we need to pass through the kind parameter from createEfficiencies and use that to determine what type of workspaces to create. It looks like originally we would call createPointWs for points and point-short, but if kind == "histo" then we should be calling createHistoWS.
| alg->setProperty("InputWorkspaces", inputs); | ||
| alg->execute(); | ||
| WorkspaceGroup_sptr out = AnalysisDataService::Instance().retrieveWS<WorkspaceGroup>(OUTPUT_GRP_NAME); | ||
| checkOutputWorkspaceGroupSize(4); | ||
|
|
||
| for (size_t i = 0; i < out->size(); ++i) { |
There was a problem hiding this comment.
In test_points and test_points_short we're comparing the output and input workspaces using the CompareWorkspaces algorithm. As the code for setting up and calling this algorithm is duplicated between the two tests, could we pull this into a helper method?
rbauststfc
reviewed
Dec 19, 2024
rbauststfc
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
This refactor has significantly reduced the code duplication and should make it much easier to maintain and extend the tests in future. All code review comments have been addressed and all tests are passing. Thanks very much @yusufjimoh for all your hard work on this one.
cailafinn
deleted the
38287-maintenance-tasks-for-polarizationefficiencycor
branch
peterfpeterson
pushed a commit
to peterfpeterson/mantid
that referenced
this pull request
Jan 17, 2025
This is a squashed version of mantidproject#38458 Update Unit Tests in PolarizationEffiency Cor - wrote unit tests to check that wildes method perform well when spinstates is added - wrote unit tests to check that fredrik method throws exception when tested with wildes-only properties spinstates and flippers - wrote unit tests to check that fredrikze method can take AddSpinStateToLog property - refactored unit tests for maintainability updated hardcoded strings to use private variables refactored unit tests to reduce redudancies Simplify Tests based on code review suggestions - created efficiency output workspace method to cater for duplication in createEfficiencyWorkspace - moved functions from setAlgorithmProperties to createAlgorithm method remove duplication in test_point methods refactor createEfficiencyOutputWorkspace method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Fixes #38287
To test:
This does not require release notes because it involves updating the unit tests