Polarization tests - ornl-next #38623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a squashed version of mantidproject#38529 created helper functions to reduce code duplications in PolarizationCorrectionWildestest refactor methods with spinstates, added more helper methods to reduce code duplication removed helper methods from namespace to class as private methods in PolarizationCorrectionWildesTest - refactor and improve tests based on suggestions from code review Pulling latest state from main
This is a squashed version of mantidproject#38458 Update Unit Tests in PolarizationEffiency Cor - wrote unit tests to check that wildes method perform well when spinstates is added - wrote unit tests to check that fredrik method throws exception when tested with wildes-only properties spinstates and flippers - wrote unit tests to check that fredrikze method can take AddSpinStateToLog property - refactored unit tests for maintainability updated hardcoded strings to use private variables refactored unit tests to reduce redudancies Simplify Tests based on code review suggestions - created efficiency output workspace method to cater for duplication in createEfficiencyWorkspace - moved functions from setAlgorithmProperties to createAlgorithm method remove duplication in test_point methods refactor createEfficiencyOutputWorkspace method
peterfpeterson
merged commit a258cfe
into
mantidproject:ornl-next
9 of 10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls the following PRs into
ornl-next