fix(mobile): 分享选择模式补标题行并对齐桌面文案 - #3755
Open
Michael-Yu2978 wants to merge 2 commits into
Open
Conversation
- ShareSelectionBar 增加标题行(session.shareImage.title),已选数量改走 session.shareImage.subtitle 复数 key,文案对齐桌面 chat.shareImage - 移除不再使用的 session.shareImage.selectedCount key - en title 大小写对齐桌面(Share conversation → Share Conversation) Signed-off-by: Michael-Yu2978 <ymt2978@163.com>
|
| Filename | Overview |
|---|---|
| apps/mobile/src/session/ShareSelectionBar.tsx | 新增标题和副标题双行布局;现有弹性布局、行高及截断设置未显示出明确的功能问题。 |
| apps/mobile/src/i18n/locales/en/session.json | 将英文数量文案改为符合当前 i18next 配置的单复数键,并统一标题大小写。 |
| apps/mobile/src/i18n/locales/ja/session.json | 日文分享数量文案迁移到与其他语言一致的复数键结构。 |
| apps/mobile/src/i18n/locales/ko/session.json | 韩文分享数量文案迁移到与其他语言一致的复数键结构。 |
| apps/mobile/src/i18n/locales/zh-CN/session.json | 简体中文分享数量文案迁移到复数键并与桌面措辞对齐。 |
| apps/mobile/src/i18n/locales/zh-TW/session.json | 繁体中文分享数量文案迁移到复数键并与桌面措辞对齐。 |
Reviews (1): Last reviewed commit: "fix(mobile): 分享选择模式补标题行并对齐桌面文案" | Re-trigger Greptile
Contributor
|
命中 UI 路径( |
Contributor
|
这个 PR 改了移动端分享选择模式的可见文案和布局(补标题行、对齐桌面副标题),需要维护者确认后再合并。 请维护者直接在本 PR 上 Approve;若要改,请 Request Changes。讨论 issue:#3756 |
Signed-off-by: Michael Yu <michael.yu2978@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
这次改了什么
摘要
移动端分享选择模式(底部操作条)原先只有
[关闭][已选 N 条][分享],没有标题头;桌面端同一入口渲染title(分享对话)+subtitle(已选 N 条消息)两行。本 PR 把规划好但一直没接线的死 keysession.shareImage.title(五个语言文件都有,rg全仓零引用)接成真实 UI,并新增session.shareImage.subtitle复数 key,文案与桌面逐字对齐。变更类型
fix缺陷修复范围
ShareSelectionBar增加标题行;五个 locale 新增session.shareImage.subtitle复数 key;删除随之闲置的selectedCountkey;entitle大小写对齐桌面;补充 UI 复刻证据(docs/design-previews/share-selection-bar-title/)UI 变化
apps/mobile/docs/mobile-design-guide.md(文字层级:主=textPrimary、次=textSecondary;字号角色:正文body、metadata/标签caption)。标题行用textPrimary/typeScale.body/fontWeight.medium,副标题用textSecondary/typeScale.caption,颜色全部走语义 token,Light/Dark 双模式由 token 系统同源覆盖;两行布局与桌面ShareSelectionBar的 title + subtitle 结构对齐。怎么验证的
自动验证
注:环境默认 pnpm 为 11.x,与仓库
engines.pnpm(>=10.7 <11)冲突,上述命令均用corepack pnpm(10.33.2,即packageManager锁定版本)执行。手工验证
附渲染复刻证据(明确标注:非真机/模拟器截图,是基于真实 token 的复刻渲染):
docs/design-previews/share-selection-bar-title/evidence/light.png(zh-CN Light)docs/design-previews/share-selection-bar-title/evidence/dark.png(zh-CN Dark)docs/design-previews/share-selection-bar-title/evidence/en-light.png(en Light,展示复数2 messages selected)docs/design-previews/share-selection-bar-title/evidence/en-dark.png(en Dark)复刻页
docs/design-previews/share-selection-bar-title/index.html的配色/字号/间距全部取自apps/mobile/src/theme/tokens.ts与lightColors/darkColors(surfaceTranslucent、borderTranslucent、textPrimary、textSecondary、cta、ctaText、typeScale.body/caption、lineHeight.body/caption、spacing、radius.pill、iconSize、iconStroke),文案为本次改动的真实译文(zh-CN「分享对话 / 已选 2 条消息」,en「Share Conversation / 2 messages selected」)。未执行的验证
nativeConversationShareAvailable = Platform.OS === 'ios'),本机为 Windows、无 iOS 环境;也未安装 Android SDK / maestro,Android 上分享入口不可达,故无法产出真机截图。风险
风险分类
影响与回滚
app.json/eas.json/ config plugin,不改变 runtime fingerprint(无冷更)。提交前检查
git commit -s,本地pnpm check:dco通过)