Skip to content

chore: Add ci support for liblogosdeliery, build and artifacts #3746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NagyZoltanPeter wants to merge 1 commit into
base: master
Choose a base branch
from
+49 −1
Open

chore: Add ci support for liblogosdeliery, build and artifacts #3746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci-nix.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ jobs:
- libwaku
- libwaku-android-arm64
- wakucanary
- liblogosdelivery

exclude:
# Android SDK limitation
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ jobs:
- 'Makefile'
- 'waku.nimble'
- 'library/**'
- 'liblogosdelivery/**'
v2:
- 'waku/**'
- 'apps/**'
Expand Down
48 changes: 47 additions & 1 deletion .github/workflows/release-assets.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
push:
tags:
- 'v*' # "e.g. v0.4"

workflow_dispatch:

env:
Expand Down Expand Up @@ -65,6 +65,16 @@ jobs:

echo "libwaku=${LIBWAKU_ARTIFACT_NAME}" >> $GITHUB_OUTPUT

if [[ "${{ runner.os }}" == "Linux" ]]; then
LIBLOGOSDELIVERY_ARTIFACT_NAME=$(echo "liblogosdelivery-${VERSION}-${{matrix.arch}}-${{runner.os}}-linux.deb" | tr "[:upper:]" "[:lower:]")
fi

if [[ "${{ runner.os }}" == "macOS" ]]; then
LIBLOGOSDELIVERY_ARTIFACT_NAME=$(echo "liblogosdelivery-${VERSION}-${{matrix.arch}}-macos.tar.gz" | tr "[:upper:]" "[:lower:]")
fi

echo "liblogosdelivery=${LIBLOGOSDELIVERY_ARTIFACT_NAME}" >> $GITHUB_OUTPUT

- name: Install build dependencies
run: |
if [[ "${{ runner.os }}" == "Linux" ]]; then
Expand All @@ -83,6 +93,9 @@ jobs:
make -j${NPROC} NIMFLAGS="--parallelBuild:${NPROC} -d:disableMarchNative --os:${OS} --cpu:${{matrix.arch}} -d:postgres" CI=false libwaku
make -j${NPROC} NIMFLAGS="--parallelBuild:${NPROC} -d:disableMarchNative --os:${OS} --cpu:${{matrix.arch}} -d:postgres" CI=false STATIC=1 libwaku

make -j${NPROC} NIMFLAGS="--parallelBuild:${NPROC} -d:disableMarchNative --os:${OS} --cpu:${{matrix.arch}} -d:postgres" CI=false liblogosdelivery
make -j${NPROC} NIMFLAGS="--parallelBuild:${NPROC} -d:disableMarchNative --os:${OS} --cpu:${{matrix.arch}} -d:postgres" CI=false STATIC=1 liblogosdelivery
Comment on lines +96 to +97
Copy link

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step now builds liblogosdelivery in addition to the Waku artifacts, but the step name is still "Build Waku artifacts". Consider renaming the step to something broader (e.g., "Build artifacts") so CI logs remain accurate and easier to scan.

Copilot uses AI. Check for mistakes.

- name: Create distributable libwaku package
run: |
VERSION=${{ steps.version.outputs.version }}
Expand All @@ -109,6 +122,32 @@ jobs:
tar -cvzf ${{steps.vars.outputs.libwaku}} ./build/libwaku.dylib ./build/libwaku.a ./library/libwaku.h
fi

- name: Create distributable liblogosdelivery package
run: |
VERSION=${{ steps.version.outputs.version }}

if [[ "${{ runner.os }}" == "Linux" ]]; then
rm -rf pkg
mkdir -p pkg/DEBIAN pkg/usr/local/lib pkg/usr/local/include
cp build/liblogosdelivery.so pkg/usr/local/lib/
cp build/liblogosdelivery.a pkg/usr/local/lib/
cp liblogosdelivery/liblogosdelivery.h pkg/usr/local/include/

echo "Package: logosdelivery" >> pkg/DEBIAN/control
echo "Version: ${VERSION}" >> pkg/DEBIAN/control
echo "Priority: optional" >> pkg/DEBIAN/control
echo "Section: libs" >> pkg/DEBIAN/control
echo "Architecture: ${{matrix.arch}}" >> pkg/DEBIAN/control
echo "Maintainer: Logos Messaging Team" >> pkg/DEBIAN/control
Copy link

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Debian control file sets Maintainer: Logos Messaging Team without an email address. Debian tooling and downstream consumers typically expect the Maintainer field to be in Name <email> form, and this workflow already follows that pattern for the libwaku package. Please update this field to include a contact email (or reuse an existing team address) for consistency and better package metadata hygiene.

Suggested change
echo "Maintainer: Logos Messaging Team" >> pkg/DEBIAN/control
echo "Maintainer: Logos Messaging Team <ivansete@status.im>" >> pkg/DEBIAN/control

Copilot uses AI. Check for mistakes.
echo "Description: Logos Delivery library" >> pkg/DEBIAN/control

dpkg-deb --build pkg ${{steps.vars.outputs.liblogosdelivery}}
fi

if [[ "${{ runner.os }}" == "macOS" ]]; then
tar -cvzf ${{steps.vars.outputs.liblogosdelivery}} ./build/liblogosdelivery.dylib ./build/liblogosdelivery.a ./liblogosdelivery/liblogosdelivery.h
fi

- name: Upload waku artifact
uses: actions/upload-artifact@v4.4.0
with:
Expand All @@ -122,3 +161,10 @@ jobs:
name: libwaku-${{ steps.version.outputs.version }}-${{ matrix.arch }}-${{ runner.os }}
path: ${{ steps.vars.outputs.libwaku }}
if-no-files-found: error

- name: Upload liblogosdelivery artifact
uses: actions/upload-artifact@v4.4.0
with:
name: liblogosdelivery-${{ steps.version.outputs.version }}-${{ matrix.arch }}-${{ runner.os }}
path: ${{ steps.vars.outputs.liblogosdelivery }}
if-no-files-found: error
Loading