chore: Add ci support for liblogosdeliery, build and artifacts#3746
chore: Add ci support for liblogosdeliery, build and artifacts#3746NagyZoltanPeter wants to merge 1 commit intomasterfrom
Conversation
NagyZoltanPeter
requested review from
Ivansete-status,
Copilot,
darshankabariya and
fcecin
There was a problem hiding this comment.
Pull request overview
Adds CI/release workflow support for building and publishing artifacts for the new liblogosdelivery library, aligning it with the existing libwaku handling.
Changes:
- Extend the release assets workflow to build
liblogosdelivery, package it for Linux/macOS, and upload it as an artifact. - Update the main CI paths filter so
liblogosdelivery/**changes trigger the relevant jobs. - Add
liblogosdeliveryto the Nix CI build matrix.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/release-assets.yml | Build + package + upload release artifacts for liblogosdelivery on Linux/macOS. |
| .github/workflows/ci.yml | Include liblogosdelivery/** in change detection to trigger CI. |
| .github/workflows/ci-nix.yml | Add liblogosdelivery to the Nix build matrix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| echo "Priority: optional" >> pkg/DEBIAN/control | ||
| echo "Section: libs" >> pkg/DEBIAN/control | ||
| echo "Architecture: ${{matrix.arch}}" >> pkg/DEBIAN/control | ||
| echo "Maintainer: Logos Messaging Team" >> pkg/DEBIAN/control |
There was a problem hiding this comment.
The Debian control file sets Maintainer: Logos Messaging Team without an email address. Debian tooling and downstream consumers typically expect the Maintainer field to be in Name <email> form, and this workflow already follows that pattern for the libwaku package. Please update this field to include a contact email (or reuse an existing team address) for consistency and better package metadata hygiene.
| echo "Maintainer: Logos Messaging Team" >> pkg/DEBIAN/control | |
| echo "Maintainer: Logos Messaging Team <ivansete@status.im>" >> pkg/DEBIAN/control |
| make -j${NPROC} NIMFLAGS="--parallelBuild:${NPROC} -d:disableMarchNative --os:${OS} --cpu:${{matrix.arch}} -d:postgres" CI=false liblogosdelivery | ||
| make -j${NPROC} NIMFLAGS="--parallelBuild:${NPROC} -d:disableMarchNative --os:${OS} --cpu:${{matrix.arch}} -d:postgres" CI=false STATIC=1 liblogosdelivery |
There was a problem hiding this comment.
This step now builds liblogosdelivery in addition to the Waku artifacts, but the step name is still "Build Waku artifacts". Consider renaming the step to something broader (e.g., "Build artifacts") so CI logs remain accurate and easier to scan.
|
You can find the image built from this PR at Built from add885e |
Description
Found we were missing CI build and artifact handling of new API lib: liblogosdelivery.
This PR adds the same support for it as libwaku.