first draft of race2 #56
Conversation
AlexanderFengler
left a comment
AlexanderFengler
left a comment
There was a problem hiding this comment.
left some comments that need to be addressed
src/race2_draft.ipynb
Outdated
There was a problem hiding this comment.
this file shouldn't sit in this particular folder
There was a problem hiding this comment.
(not sure if it should exist at all)
ssms/config/config.py
Outdated
| }, | ||
| "ddm_seq2_no_bias_race2": { | ||
| "name": "ddm_seq2_no_bias_race2", | ||
| "params": ["vha", "vhb", "vl1a", "vl1b", "vl2a", "vl2b" , "a", "t"], |
There was a problem hiding this comment.
the v settings are a bit aggressive.
maybe -3.0, 3.0?
Was there a reason to set them to -4, 4?
There was a problem hiding this comment.
Looking over the simulator, moreover in this context you want the bounds on v parameters generally to have a lower bound of 0.
In the race model version, negative drifts don't really make sense (not in our context at least).
| float max_t = 20, | ||
| int n_samples = 20000, | ||
| int n_trials = 1, | ||
| print_info = True, |
There was a problem hiding this comment.
print_info is an option only for this simulator right?
In which case I would skip it for consistency.
There was a problem hiding this comment.
print_info = True is also there on the other 4-choice simulators
|
Tests also failing, needs investigation. |
|
@anvo2 ping on this. Comments being addressed? |
|
@anvo2 the tests are failing still. |
AlexanderFengler
left a comment
AlexanderFengler
left a comment
There was a problem hiding this comment.
@anvo2 just address the remaining issues then we can merge this.
anvo2
left a comment
anvo2
left a comment
There was a problem hiding this comment.
I believe everything is all set?
|
please ignore the entire block of seq2_short. That will get deleted out. |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
2 participants
Might recode the particles into a separate dim if necessary