[TOSA] TOSA updates for LLVM hash 5d6d982 #3992
Open
+936
−538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* TOSA requires operands' and result's ranks to be same according to the SameOperandsAndResultRank trait (link to LLVM PR: https://github.com/llvm/llvm-project/pull/104501/files). * Use EqualizeRanks() function to equalize ranks among operands and results before creating TOSA ops. * Update LIT tests. Signed-off-by: Justin Ngo <[email protected]> Change-Id: I48a8ebe82ec462026181abfde3ce1e129226e0bd
* Update tosa.pad with padding input as type !tosa.shape<rank * 2> * Update LIT test Signed-off-by: Justin Ngo <[email protected]> Change-Id: I12e12060f710e144fcb0da67910b388199fdc527
* TOSA ops' maximum, minimum, reduce_max, reduce_min, max_pool, clamp, and argmax has a new NaN propagation mode added as an attribute. LLVM PR: llvm/llvm-project#121951 * Add NaN Propagation mode attributes to the ops mentioned above in Torch to TOSA legalization. Signed-off-by: Justin Ngo <[email protected]> Change-Id: I27dfda9d0146da8742f14718c713998c436899ce
* `isF...()` APIs are deprecated for low-precision FP types like Float4E2M1FN according to this LLVM PR: llvm/llvm-project#123326 * These API usages are replaced with `isa<Float...Type>(type)` instead. For example: `isa<Float4E2M1FNType>(type)` Signed-off-by: Justin Ngo <[email protected]> Change-Id: Ia6073987cb4348fa4a701bc182f961786e85e20c
Signed-off-by: Justin Ngo <[email protected]> Change-Id: I4e1c19869b90903058f2f3f8b934191b85efe5ef
justin-ngo-arm
changed the title
Signed-off-by: Justin Ngo <[email protected]> Change-Id: I1ad7276cf2985ebb2e2a52fdfe596d6a4f28125c
sjarus
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary:
isF...()APIs for low-precision FP