Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump llvm to llvm/llvm-project@5d6d982 #3994

Merged
merged 7 commits into from
Jan 31, 2025

Conversation

praveen-g-ctt
Copy link
Contributor

@praveen-g-ctt praveen-g-ctt commented Jan 30, 2025

Update llvm-project to 5d6d982df61d16b6d498e6d59dd91c059679d3d8
Update stablehlo to b62dc66da9946b4c400c0d99c9d5bb8e04edaee6

Co-authored-by: Justin Ngo [email protected]

* TOSA requires operands' and result's ranks to be same according to
  the SameOperandsAndResultRank trait (link to LLVM PR:
  https://github.com/llvm/llvm-project/pull/104501/files).
* Use EqualizeRanks() function to equalize ranks among operands and
  results before creating TOSA ops.
* Update LIT tests.

Signed-off-by: Justin Ngo <[email protected]>
Change-Id: I48a8ebe82ec462026181abfde3ce1e129226e0bd
* Update tosa.pad with padding input as type !tosa.shape<rank * 2>
* Update LIT test

Signed-off-by: Justin Ngo <[email protected]>
Change-Id: I12e12060f710e144fcb0da67910b388199fdc527
* TOSA ops' maximum, minimum, reduce_max, reduce_min, max_pool, clamp,
  and argmax has a new NaN propagation mode added as an attribute.
  LLVM PR: llvm/llvm-project#121951
* Add NaN Propagation mode attributes to the ops mentioned above in
  Torch to TOSA legalization.

Signed-off-by: Justin Ngo <[email protected]>
Change-Id: I27dfda9d0146da8742f14718c713998c436899ce
* `isF...()` APIs are deprecated for low-precision FP types like
  Float4E2M1FN according to this LLVM PR:
  llvm/llvm-project#123326
* These API usages are replaced with `isa<Float...Type>(type)` instead.
  For example: `isa<Float4E2M1FNType>(type)`

Signed-off-by: Justin Ngo <[email protected]>
Change-Id: Ia6073987cb4348fa4a701bc182f961786e85e20c
Signed-off-by: Justin Ngo <[email protected]>
Change-Id: I4e1c19869b90903058f2f3f8b934191b85efe5ef
Signed-off-by: Justin Ngo <[email protected]>
Change-Id: I1ad7276cf2985ebb2e2a52fdfe596d6a4f28125c
@praveen-g-ctt praveen-g-ctt changed the title Bump llvm 5d6d982 Bump llvm to 5d6d982 Jan 30, 2025
Copy link
Member

@pashu123 pashu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message: Bump llvm and stable hlo.
Body: llvm-project@hash and stable_hlo@hash.

LGTM!

Update llvm-project to 5d6d982df61d16b6d498e6d59dd91c059679d3d8
Update stablehlo to b62dc66da9946b4c400c0d99c9d5bb8e04edaee6

Signed-off-by: Praveen G <[email protected]>
Co-authored-by: Justin Ngo <[email protected]>
@pashu123 pashu123 changed the title Bump llvm to 5d6d982 Bump llvm to llvm/llvm-project@5d6d982 Jan 30, 2025
@pashu123
Copy link
Member

@vivekkhandelwal1 Could you take a look?

Copy link
Collaborator

@sjarus sjarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming you're picking up #3992 cc: @justin-ngo-arm

Copy link
Collaborator

@vivekkhandelwal1 vivekkhandelwal1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @praveen-g-ctt please add @justin-ngo-arm as a co-author.

@praveen-g-ctt
Copy link
Contributor Author

LGTM. @praveen-g-ctt please add @justin-ngo-arm as a co-author.

Yes, Have added @justin-ngo-arm as the co-author

@pashu123 pashu123 merged commit 1690320 into llvm:main Jan 31, 2025
3 checks passed
@praveen-g-ctt praveen-g-ctt deleted the bump_llvm_5d6d982 branch January 31, 2025 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants