Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Changed setup.py for wheel building to a more stable version #3105

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[build] Changed setup.py for wheel building to a more stable version #3105

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c7a844
Changed setup.py for wheel building to a more stable version
Apr 3, 2024
029ebfd
Merge branch 'llvm:main' into torch14
afalkenberg1 Apr 8, 2024
510c604
Merge branch 'llvm:main' into torch14
afalkenberg1 Apr 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def check_env_flag(name: str, default=None) -> bool:
PACKAGE_VERSION = os.environ.get("TORCH_MLIR_PYTHON_PACKAGE_VERSION") or "0.0.1"

# If true, enable LTC build by default
TORCH_MLIR_ENABLE_LTC_DEFAULT = True
TORCH_MLIR_ENABLE_LTC_DEFAULT = False
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you need to disable LTC? What build failures do you encounter using clang?

TORCH_MLIR_ENABLE_ONLY_MLIR_PYTHON_BINDINGS = check_env_flag(
'TORCH_MLIR_ENABLE_ONLY_MLIR_PYTHON_BINDINGS', False)
LLVM_INSTALL_DIR = os.getenv('LLVM_INSTALL_DIR', None)
Expand Down Expand Up @@ -88,6 +88,10 @@ def cmake_build(self, cmake_build_dir):
f"-DMLIR_ENABLE_BINDINGS_PYTHON=ON",
f"-DLLVM_TARGETS_TO_BUILD=host",
f"-DLLVM_ENABLE_ZSTD=OFF",
f"-DCMAKE_C_COMPILER=clang",
f"-DCMAKE_CXX_COMPILER=clang++",
f"-DCMAKE_C_COMPILER_LAUNCHER=ccache",
f"-DCMAKE_CXX_COMPILER_LAUNCHER=ccache",
# Optimization options for building wheels.
f"-DCMAKE_VISIBILITY_INLINES_HIDDEN=ON",
f"-DCMAKE_C_VISIBILITY_PRESET=hidden",
Expand Down
Loading