[build] Changed setup.py for wheel building to a more stable version #3105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afalkenberg1
changed the title
|
maybe someone can comment on this ? |
antoniojkim
reviewed
Apr 15, 2024
| @@ -49,7 +49,7 @@ def check_env_flag(name: str, default=None) -> bool: | |||
| PACKAGE_VERSION = os.environ.get("TORCH_MLIR_PYTHON_PACKAGE_VERSION") or "0.0.1" | |||
|
|
|||
| # If true, enable LTC build by default | |||
| TORCH_MLIR_ENABLE_LTC_DEFAULT = True | |||
| TORCH_MLIR_ENABLE_LTC_DEFAULT = False | |||
There was a problem hiding this comment.
Why did you need to disable LTC? What build failures do you encounter using clang?
|
Hi @afalkenberg1, do we still need this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using the setup.py to build a wheel as for example in:
CMAKE_GENERATOR=Ninja python setup.py bdist_wheel --dist-dir ./torch-mlir-wheel -v
pip uninstall torch-mlir
pip install torch-mlir-wheel/torch_mlir-0.0.1-cp310-cp310-linux_x86_64.whl
I found that I needed to change setup.py to use clang, ccache and also turn off LTC by setting
TORCH_MLIR_ENABLE_LTC_DEFAULT=False.
This usually led to a version which I can usually build without any additional problems.
Not sure if this might be of general interest and warrant a PR.
Thank you