Skip to content

clamp connection timeout and fixed the comment #748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −1
Open

clamp connection timeout and fixed the comment #748

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion livekit/src/room/participant/local_participant.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -740,6 +740,7 @@ impl LocalParticipant {
// This is set to 7 seconds to account for various relay timeouts and retries in LiveKit Cloud that occur in rare cases

let max_round_trip_latency = Duration::from_millis(7000);
let min_effective_timeout = Duration::from_millis(1000);

if data.payload.len() > MAX_PAYLOAD_BYTES {
return Err(RpcError::built_in(RpcErrorCode::RequestPayloadTooLarge, None));
Expand All @@ -760,7 +761,9 @@ impl LocalParticipant {
let id = create_random_uuid();
let (ack_tx, ack_rx) = oneshot::channel();
let (response_tx, response_rx) = oneshot::channel();
let effective_timeout = data.response_timeout - max_round_trip_latency;
let effective_timeout = std::cmp::max(
data.response_timeout.saturating_sub(max_round_trip_latency),
min_effective_timeout);

match self
.publish_rpc_request(RpcRequest {
Expand Down
Loading