Skip to content

Conversation

xianshijing-lk
Copy link
Contributor

So the problem is that the performRpc is a public function, and we never sanity check if users provide values larger than the connection_timeout, which might cause unexpected behavior.

This PR fixes the comment and also clamp the connection response timeout if needed.

Copy link
Contributor

@ladvoc ladvoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good! Two notes:

  • The build failure on Android is not related to this PR—I am investigating the cause
  • To make the format check pass, run cargo fmt and commit the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants