Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure the inner client of either BigTableConnection or BigTable #96

Merged
merged 2 commits into from
Oct 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions bigtable_rs/src/bigtable.rs
Original file line number Diff line number Diff line change
Expand Up @@ -403,6 +403,14 @@ impl BigTableConnection {
timeout: self.timeout.clone(),
}
}

/// Provide a convenient method to update the inner `BigtableClient` so a newly configured client can be set
pub fn configure_inner_client(
&mut self,
config_fn: fn(BigtableClient<AuthSvc>) -> BigtableClient<AuthSvc>,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, one more thing, is it possible to pass in a &mut here, so we do not need to do the clone below?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, maybe that clone is not avoidable? Haven't written Rust for a while so my Rust is a bit rusty...

) {
self.client = config_fn(self.client.clone());
}
}

/// Helper function to create a BigtableClient<AuthSvc>
Expand Down Expand Up @@ -523,6 +531,14 @@ impl BigTable {
&mut self.client
}

/// Provide a convenient method to update the inner `BigtableClient` config
pub fn configure_inner_client(
&mut self,
config_fn: fn(BigtableClient<AuthSvc>) -> BigtableClient<AuthSvc>,
) {
self.client = config_fn(self.client.clone());
}

/// Provide a convenient method to get full table, which can be used for building requests
pub fn get_full_table_name(&self, table_name: &str) -> String {
[&self.table_prefix, table_name].concat()
Expand Down
4 changes: 4 additions & 0 deletions examples/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@ path = "src/http_server/http_server.rs"
name = "custom_path_connection"
path = "src/custom_path_connection.rs"

[[bin]]
name = "configure_inner_client"
path = "src/configure_inner_client.rs"

[[bin]]
name = "prefix"
path = "src/prefix.rs"
Expand Down
41 changes: 41 additions & 0 deletions examples/src/configure_inner_client.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
use bigtable_rs::bigtable;
use env_logger;
use gcp_auth::CustomServiceAccount;
use std::error::Error;
use std::sync::Arc;
use std::time::Duration;
use std::usize;

#[tokio::main]
async fn main() -> Result<(), Box<dyn Error>> {
env_logger::init();

let project_id = "project-1";
let instance_name = "instance-1";
let channel_size = 4;
let timeout = Duration::from_secs(10);

let json_path: &str = "examples/src/custom_path_fake_key.json";
// make a bigtable client
let mut connection = bigtable::BigTableConnection::new_with_token_provider(
project_id,
instance_name,
false,
channel_size,
Some(timeout),
Arc::new(CustomServiceAccount::from_file(json_path).unwrap()),
)?;

// update the config for the inner client of the connection
connection
.configure_inner_client(|inner_client| inner_client.max_decoding_message_size(usize::MAX));

let mut client = connection.client();

// or update the config one step later
client.configure_inner_client(|inner_client| {
inner_client.max_decoding_message_size(2 * 1024 * 1024)
});

Ok(())
}
Loading