configure the inner client of either BigTableConnection or BigTable #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JorritSalverda Thank you for adding this feature. Do you mind rebasing onto current main and I will let the CI build run again? :) |
liufuyang
approved these changes
Oct 17, 2024
JorritSalverda
force-pushed
the
configure-inner-client
branch
from
2712533 to
287615e
Compare
liufuyang
reviewed
Oct 17, 2024
…o change settings like max_decoding_message_size
JorritSalverda
force-pushed
the
configure-inner-client
branch
from
a0c911a to
d7ecf5c
Compare
|
Hi @liufuyang , it's rebased from your latest changes in main now. |
liufuyang
reviewed
Oct 17, 2024
| /// Provide a convenient method to update the inner `BigtableClient` so a newly configured client can be set | ||
| pub fn configure_inner_client( | ||
| &mut self, | ||
| config_fn: fn(BigtableClient<AuthSvc>) -> BigtableClient<AuthSvc>, |
There was a problem hiding this comment.
Oh, one more thing, is it possible to pass in a &mut here, so we do not need to do the clone below?
There was a problem hiding this comment.
Nevermind, maybe that clone is not avoidable? Haven't written Rust for a while so my Rust is a bit rusty...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to change settings like max_decoding_message_size
Solves #95