-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add null-ptr-check on UrlDetector & InputTextReader #9
Open
XinyueZ
wants to merge
1
commit into
linkedin:master
Choose a base branch
from
XinyueZ:add-null-ptr-check-InputTextReader
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+19
−2
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,9 @@ | ||
apply plugin: 'java' | ||
apply plugin: 'idea' | ||
|
||
dependencies { | ||
sourceCompatibility = 1.7 | ||
targetCompatibility = 1.7 | ||
|
||
compile 'org.apache.commons:commons-lang3:3.4' | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -42,8 +42,13 @@ public class InputTextReader { | |
/** | ||
* Creates a new instance of the InputTextReader using the content to read. | ||
* @param content The content to read. | ||
* @throws {@link NullPointerException} if {@code content == null} . | ||
*/ | ||
public InputTextReader(String content) { | ||
public InputTextReader(String content) throws NullPointerException { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How about let's use import javax.annotation.@nonnull instead? Static compile checks seem better than throwing a different type of NPE |
||
if (content == null) { | ||
throw new NullPointerException("content must't be null."); | ||
} | ||
|
||
_content = content.toCharArray(); | ||
} | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,6 +12,7 @@ | |
import com.linkedin.urls.Url; | ||
import com.linkedin.urls.UrlMarker; | ||
import com.linkedin.urls.UrlPart; | ||
|
||
import java.util.ArrayList; | ||
import java.util.Arrays; | ||
import java.util.Collections; | ||
|
@@ -119,8 +120,13 @@ public enum ReadEndState { | |
* Creates a new UrlDetector object used to find urls inside of text. | ||
* @param content The content to search inside of. | ||
* @param options The UrlDetectorOptions to use when detecting the content. | ||
* @throws {@link NullPointerException} if {@code content == null} . | ||
*/ | ||
public UrlDetector(String content, UrlDetectorOptions options) { | ||
public UrlDetector(String content, UrlDetectorOptions options) throws NullPointerException { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same here. |
||
if (content == null) { | ||
throw new NullPointerException("content must't be null."); | ||
} | ||
|
||
_reader = new InputTextReader(content); | ||
_options = options; | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still needed with the latest pull?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is no needed more