Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add null-ptr-check on UrlDetector & InputTextReader #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions url-detector/build.gradle
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
apply plugin: 'java'
apply plugin: 'idea'

dependencies {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still needed with the latest pull?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is no needed more

sourceCompatibility = 1.7
targetCompatibility = 1.7

compile 'org.apache.commons:commons-lang3:3.4'
}
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,13 @@ public class InputTextReader {
/**
* Creates a new instance of the InputTextReader using the content to read.
* @param content The content to read.
* @throws {@link NullPointerException} if {@code content == null} .
*/
public InputTextReader(String content) {
public InputTextReader(String content) throws NullPointerException {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about let's use import javax.annotation.@nonnull instead? Static compile checks seem better than throwing a different type of NPE

if (content == null) {
throw new NullPointerException("content must't be null.");
}

_content = content.toCharArray();
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
import com.linkedin.urls.Url;
import com.linkedin.urls.UrlMarker;
import com.linkedin.urls.UrlPart;

import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
Expand Down Expand Up @@ -119,8 +120,13 @@ public enum ReadEndState {
* Creates a new UrlDetector object used to find urls inside of text.
* @param content The content to search inside of.
* @param options The UrlDetectorOptions to use when detecting the content.
* @throws {@link NullPointerException} if {@code content == null} .
*/
public UrlDetector(String content, UrlDetectorOptions options) {
public UrlDetector(String content, UrlDetectorOptions options) throws NullPointerException {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here.

if (content == null) {
throw new NullPointerException("content must't be null.");
}

_reader = new InputTextReader(content);
_options = options;
}
Expand Down