Add null-ptr-check on UrlDetector & InputTextReader #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzuhanjan
requested changes
May 19, 2017
| */ | ||
| public InputTextReader(String content) { | ||
| public InputTextReader(String content) throws NullPointerException { |
There was a problem hiding this comment.
How about let's use import javax.annotation.@nonnull instead? Static compile checks seem better than throwing a different type of NPE
| */ | ||
| public UrlDetector(String content, UrlDetectorOptions options) { | ||
| public UrlDetector(String content, UrlDetectorOptions options) throws NullPointerException { |
| @@ -1,3 +1,9 @@ | |||
| apply plugin: 'java' | |||
| apply plugin: 'idea' | |||
|
|
|||
| dependencies { | |||
There was a problem hiding this comment.
Is this still needed with the latest pull?
|
@tzuhanjan Greetings! Could you accept the request or ask someone to? Thank you! |
|
@leffsu, @tzuhanjan if don't mind I want to continue clean up the PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.