wasm: detailed rpc logs #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViktorTigerstrom
approved these changes
Feb 20, 2025
jbrill
force-pushed
the
rpc-debug-logs
branch
from
3942ff3 to
dde87b5
Compare
Perfect! Thanks for the review 😄 pushed up those line length modifications! |
|
@jbrill - we usually wait for 2 ACKs before merging things |
ellemouton
reviewed
Feb 25, 2025
Comment on lines
+330
to
331
| "parameters: rpcName, request, callback") | ||
| return js.ValueOf("invalid use of wasmClientInvokeRPC, " + |
| return js.ValueOf("invalid use of wasmClientInvokeRPC, " + | ||
| "need 3 parameters: rpcName, request, callback") | ||
| } | ||
|
|
||
| if w.lndConn == nil { | ||
| log.Errorf("Attempted to invoke RPC but connection is not "+ | ||
| "ready") |
| @@ -340,16 +344,29 @@ func (w *wasmClient) InvokeRPC(_ js.Value, args []js.Value) interface{} { | |||
|
|
|||
| method, ok := w.registry[rpcName] | |||
| if !ok { | |||
| log.Errorf("RPC method '%s' not found in registry", rpcName) | |||
| return js.ValueOf("rpc with name " + rpcName + " not found") | |||
| return js.ValueOf("rpc with name " + rpcName + " not found") | ||
| } | ||
|
|
||
| go func() { | ||
| defer func() { |
There was a problem hiding this comment.
have we seen such panics happen?
| jsCallback.Invoke(js.ValueOf(err.Error())) | ||
| } else { | ||
| log.Debugf("RPC '%s' succeeded with result: %s", |
There was a problem hiding this comment.
would Trace make more sense?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RPC Debug Improvements for WASM Client
Problem
When attempting to call new RPC methods, the frontend would hang without providing any useful debugging information, making it difficult to diagnose issues with RPC registration and execution.
Solution
Enhanced the logging and debugging capabilities of the WASM client's RPC system by:
Changes
Testing
To test these changes:
You should see a log in the console like the following:
Notes
These changes are purely diagnostic and do not modify any functional behavior of the WASM client.