wasm: detailed rpc logs nits #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ellemouton apologies for the premature merge. This PR should address your comments, all of which I agree on ! |
ellemouton
approved these changes
Feb 25, 2025
| return js.ValueOf("rpc with name " + rpcName + " not found") | ||
| } | ||
|
|
||
| go func() { | ||
| defer func() { |
There was a problem hiding this comment.
what was the original reason for adding this panic recovery log?
There was a problem hiding this comment.
I never actually ran into a panic here, but I thought it couldn't hurt to add these logs in the case that we hit that recovery state.
ViktorTigerstrom
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional modifications from #110