Update rockspec and README, remove Makefile #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lua-vips-1.1-10.rockspec
Outdated
| @@ -34,5 +47,6 @@ build = { | |||
| ["vips.Image"] = "src/vips/Image.lua", | |||
| ["vips.Image_methods"] = "src/vips/Image_methods.lua", | |||
| ["vips.Interpolate"] = "src/vips/Interpolate.lua" | |||
| } | |||
| }, | |||
| copy_directories = { "example" } | |||
There was a problem hiding this comment.
Is there a point in copying the example directory? As in, do you expect users to navigate into their Luarocks install directory to run the example code?
There was a problem hiding this comment.
Yeah, not sure about it. I thought it was good practice to copy directories like "docs" or "examples". Looking at some widely used modules it doesn't look so. I'll remove it then.
|
Looks good to me; nice work! |
|
Thanks for the review @RiskoZoSlovenska |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the rockspec (rockspec-format, labels, dependencies, test, copy-directories).
luaffi-tklis now a dependency oflua-vips. LuaJIT users will have to exhibit this module as provided by the VM by editing theconfig-5.1.luaor by runningluarocks config --lua-version=5.1 rocks_provided.luaffi-tkl 2.1-1. Ideally this would be listed in https://github.com/luarocks/luarocks/blob/c16bdbc4cbb98c560fb7e8d4895d4d84afca2eb9/src/luarocks/util.lua#L599-L604, so LuaJIT user's wouldn't have to do it manually, but that would only work for those with an up to date luarocks then.When running
luarocks testin thelua-vipsdirectory the test-dependencybustedis automatically installed, if it is not found.Updated the README (where
lua-vipsworks and where it is tested, how to install on Windows MinGW-w64).Removed the Makefile, as it is not needed any longer. @RiskoZoSlovenska What do you think about it?