Add a notification when failing to load .7z/.zip #320
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when you try to load a game from a .7z/.zip archive the core closes with a generic "Failed to load content" and can even crash RetroArch depending on the video driver. In any case nothing is printed in logs, so the user has absolutely no idea why it's failing/crashing.
With this PR the user gets a notification (which is also printed in logs) to warn them that the core doesn't support compressed content:
dolphin-fail.mp4
And the core should not crash (because it will return false BEFORE the
Libretro::Video::Init()call, which seems to be the culprit for the crashes).Anyway I hope this is OK, the goal is really just to give the user a reason for why it's failing, idk if there's a better way of doing it.