Skip to content

chore(tcp): remove async_std support #5955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 35 commits into from
Jun 24, 2025
Merged

chore(tcp): remove async_std support #5955

merged 35 commits into from
Jun 24, 2025

Conversation

gitToki
Copy link
Contributor

@gitToki gitToki commented Mar 25, 2025

ref #5935

crate to update:
swarm, mDNS, and the transports TCP, QUIC and DNS.

@dariusc93 dariusc93 changed the title chore!: deprecate async_std support in TCP crate chore: deprecate async_std support in TCP crate Mar 25, 2025
Copy link
Member

@dariusc93 dariusc93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Left a couple of comments

Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we not soft deprecate and just hard deprecate? CC @elenaf9 @dariusc93

@elenaf9
Copy link
Member

elenaf9 commented Mar 26, 2025

Can we not soft deprecate and just hard deprecate? CC @elenaf9 @dariusc93

@gitToki initially did that, but I asked for a soft deprecation. I think a soft deprecation makes sense here because we might still have users that use async_std. It would a) give them time to object before we do a hard removal and b) offer a transition period for them.

Any specific reason why you'd prefer a direct removal @jxs?

@dariusc93
Copy link
Member

Can we not soft deprecate and just hard deprecate? CC @elenaf9 @dariusc93

Would there be any reason to suddenly do a hard deprecation vs soft? Imo, I think we should do a soft (though I am not against a hard one) to give users a time to switch or figure out plans on migration (or supporting the executor themselves for the respected protocols and utils).

@jxs
Copy link
Member

jxs commented Apr 3, 2025

Hi!

Any specific reason why you'd prefer a direct removal @jxs?

the reason is more work, double the PR's for something that has been declared as unmaintained, I feel redundant to have a version for users to remove their usage when they probably are already removing, added to the fact that I have seen soft deprecations lost in time.
But if you two agree that we should do soft I cede :)

@gitToki
Copy link
Contributor Author

gitToki commented Apr 13, 2025

updated, should be good. @dariusc93 please let me know if everything look good to you

@jxs jxs changed the title chore: deprecate async_std support in TCP crate feat: deprecate async_std support in TCP crate Jun 4, 2025
Copy link
Contributor

mergify bot commented Jun 4, 2025

This pull request has merge conflicts. Could you please resolve them @gitToki? 🙏

@elenaf9 elenaf9 changed the title feat: deprecate async_std support in TCP crate feat: remove async_std support in TCP crate Jun 4, 2025
Copy link
Contributor

mergify bot commented Jun 9, 2025

This pull request has merge conflicts. Could you please resolve them @gitToki? 🙏

mergify bot pushed a commit that referenced this pull request Jun 10, 2025
migrate from async-std to tokio, asked before [here](#5955 (comment))

Pull-Request: #6054.
@gitToki
Copy link
Contributor Author

gitToki commented Jun 10, 2025

dcutr and mplex fail but only the test have been updated so no version bump. It should be good now

Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patience Toki, left comments

Copy link
Contributor

mergify bot commented Jun 21, 2025

This pull request has merge conflicts. Could you please resolve them @gitToki? 🙏

Copy link
Member

@elenaf9 elenaf9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only needs to wait for #5959 to be merged, then we are good to go I think.

@jxs jxs changed the title feat: remove async_std support in TCP crate chore(tcp): remove async_std support Jun 24, 2025
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally, thanks @gitToki for driving this

@jxs jxs requested a review from elenaf9 June 24, 2025 19:27
@jxs jxs added the send-it label Jun 24, 2025
@mergify mergify bot merged commit f47e38e into libp2p:master Jun 24, 2025
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants