Skip to content

feat(libp2p/tcp): remove async_std from uds #6060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 25, 2025
Merged

feat(libp2p/tcp): remove async_std from uds #6060

merged 7 commits into from
Jun 25, 2025
+9 −17

Conversation

PoulavBhowmick03
Copy link
Contributor

Description

Fixes #5935

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@elenaf9
Copy link
Member

elenaf9 commented Jun 14, 2025

Thanks for the PR. There is actually already PR #5955 for removing async_std support in libp2p-tcp, but uds part is new, so would you mind just extracting that?

@PoulavBhowmick03
Copy link
Contributor Author

Thanks for the PR. There is actually already PR #5955 for removing async_std support in libp2p-tcp, but uds part is new, so would you mind just extracting that?

Sure. will do so!
Also, can you please take a look at #6057 once

@jxs jxs changed the title feat(libp2p/tcp): Deprecated async_std from tcp, uds, builder feat(libp2p/tcp): deprecate async_std from uds Jun 25, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 25, 2025

This pull request has merge conflicts. Could you please resolve them @PoulavBhowmick03? 🙏

elenaf9
elenaf9 approved these changes Jun 25, 2025
View reviewed changes
Copy link
Member

@elenaf9 elenaf9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@elenaf9 elenaf9 changed the title feat(libp2p/tcp): deprecate async_std from uds feat(libp2p/tcp): remove async_std from uds Jun 25, 2025
@mergify mergify bot merged commit a53c85f into libp2p:master Jun 25, 2025
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elenaf9 elenaf9 elenaf9 approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate async_std support
3 participants
@PoulavBhowmick03 @elenaf9 @jxs