Skip to content

Conversation

@z-ABYa
Copy link
Contributor

@z-ABYa z-ABYa commented Oct 15, 2025

Fixes #5443

Summary

  1. Migrated Permanently delete confirmation dialog in Edit channel > Trash > TrashModal form MessageDialogue to KModal. There were some minor UI changes, refer to the screenshots below.

Previous (MessageDialogue)
Screenshot 2025-10-14 at 10 21 39 PM

After (KModal)
Screenshot 2025-10-14 at 10 29 19 PM

  1. Updated the unit test suite accordingly, passing all tests.
Screenshot 2025-10-15 at 2 56 02 PM

@MisRob MisRob changed the title Removed MessageDialogue in favour of KModal and updated the required test suite [Remove Vuetify from Studio] Permanently delete resource confirmation dialog Oct 15, 2025
@MisRob
Copy link
Member

MisRob commented Oct 15, 2025

Thanks you @z-ABYa, we will assign a reviewer next week.

Copy link
Member

@akolson akolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @z-ABYa! Code changes look great, just a small suggestion on component targeting in the tests updated. We should be good for the merge once this small change is made. Thanks you!

Copy link
Member

@akolson akolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also notice that we now conflicts, Could you please rebase to the latest unstable and resolve any conflicts therein? Thank you

@akolson
Copy link
Member

akolson commented Oct 30, 2025

@z-ABYa Thanks for the changes. LGTM! Could you also look into the merge conflicts as well?

@z-ABYa
Copy link
Contributor Author

z-ABYa commented Nov 1, 2025

Sure @akolson. Sorry for the late reply, i was at a tech event for the last 2 days.

</KModal>
<MoveModal
v-else
v-if="moveModalOpen"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @z-ABYa! Please revert this change to the previous code, it not only breaks the restore functionality, but is also outside the scope of the issue. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @akolson, I have reverted to the previous code and made certain only the required changes are committed this time.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think this in't reverted yet. v-if="moveModalOpen" should be replaced with v-else

Copy link
Member

@akolson akolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @z-ABYa! one additional fix and we should be good for the merge. Thanks

@z-ABYa z-ABYa force-pushed the migrate-permanent-delete-dialog branch from fab996a to 81869de Compare November 4, 2025 13:47
@@ -1,173 +1,170 @@
<template>

<div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's revert this. And move the <MoveModal...> code to be a child of the div as previously. That way we keep the pr focused to the confirm dialog only. This will prevent potential regressions arising from moving around the code.

<template>
    <div>
        <FullscreenModal>
            ......
        </FullscreenModal>
        <MoveModal
            v-else
            .....
        />
    </div>
</template>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure i'll make the required changes based on the structure you have suggested.

Copy link
Member

@akolson akolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @z-ABYa! Thanks for the pr updates. I left additional comments for your recent changes. Please do take a look when you have a moment. Thanks

Copy link
Member

@akolson akolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @z-ABYa, great work on the migration.
It looks like the migration was actually completed earlier in this commit. However, your cleanup of the unused CSS is valuable and improves the codebase, so we’ll go ahead and merge this.

Feel free to shift your focus to the other issues assigned to you.
Thanks again for your contribution!

@akolson akolson merged commit 157c3fe into learningequality:unstable Nov 4, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Remove Vuetify from Studio] Permanently delete resource confirmation dialog

3 participants