Skip to content

Conversation

@z-ABYa
Copy link
Contributor

@z-ABYa z-ABYa commented Oct 22, 2025

Fixes #5485

Summary

Migrated the following buttons and confirmation dialog in Channels > Edit channel details/New channel:

  • Replaced MessageDialog by KModal
  • Replaced VBtn with the most suitable KButton
  1. Unsaved changes dialogue box:
    (Before when using MessageDialog)
Screenshot 2025-10-21 at 2 22 37 PM

(After when using KModal)
Screenshot 2025-10-21 at 2 28 10 PM

  1. Editing already existing channel (No changes)
Screenshot 2025-10-21 at 2 48 53 PM
  1. Creating new channel (No changes)
Screenshot 2025-10-21 at 2 51 06 PM

@MisRob
Copy link
Member

MisRob commented Oct 23, 2025

Thank you @z-ABYa, we will assign a reviewer within next two weeks. Meanwhile, would you resolve the conflicts?

@z-ABYa
Copy link
Contributor Author

z-ABYa commented Oct 23, 2025

I would like to if you can guide me in the right direction. Thanks @MisRob!

@MisRob
Copy link
Member

MisRob commented Oct 23, 2025

@z-ABYa there's plenty of resources on Internet about conflict resolution - I recommend to spend some time studying them and playing around with git.

@MisRob
Copy link
Member

MisRob commented Nov 3, 2025

Hi @z-ABYa, are you planning to come back to this? We're happy to review, but it would be more meaningful after the conflicts are resolved.

@z-ABYa
Copy link
Contributor Author

z-ABYa commented Nov 3, 2025

Hi @MisRob, these are the conflicts from the previous PR #5481 that i have made changes to and now passed all checks and is waiting to be reviewed by @akolson. Also, do i have to make same changes here too?

@MisRob
Copy link
Member

MisRob commented Nov 3, 2025

@z-ABYa this PR needs to have changes only for #5485, and therefore not include any changes in #5481.

You can adjust this PR in this way, but it may be easier to close it and open a new PR?

Next time, create two separate branches from unstable - a PR needs to contain changes relevant to the linked issue.

@z-ABYa z-ABYa force-pushed the button-in-edit-channel-details branch from c81afc3 to e707acd Compare November 4, 2025 13:59
@z-ABYa
Copy link
Contributor Author

z-ABYa commented Nov 4, 2025

Oh okay i can make a new PR. As for the branch i did made a new branch just for this commit - different from the one used in #5481

@MisRob MisRob self-assigned this Nov 4, 2025
@MisRob MisRob self-requested a review November 4, 2025 16:38
@z-ABYa
Copy link
Contributor Author

z-ABYa commented Nov 4, 2025

Hi @MisRob, I made a new PR #5531 for the issue #5485. Have a look when you have some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Remove Vuetify from Studio] Buttons in edit channel detals

2 participants