-
Notifications
You must be signed in to change notification settings - Fork 242
[Remove Vuetify from Studio] Buttons in edit channel details #5498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: unstable
Are you sure you want to change the base?
[Remove Vuetify from Studio] Buttons in edit channel details #5498
Conversation
|
Thank you @z-ABYa, we will assign a reviewer within next two weeks. Meanwhile, would you resolve the conflicts? |
|
I would like to if you can guide me in the right direction. Thanks @MisRob! |
|
@z-ABYa there's plenty of resources on Internet about conflict resolution - I recommend to spend some time studying them and playing around with git. |
|
Hi @z-ABYa, are you planning to come back to this? We're happy to review, but it would be more meaningful after the conflicts are resolved. |
|
@z-ABYa this PR needs to have changes only for #5485, and therefore not include any changes in #5481. You can adjust this PR in this way, but it may be easier to close it and open a new PR? Next time, create two separate branches from |
c81afc3 to
e707acd
Compare
|
Oh okay i can make a new PR. As for the branch i did made a new branch just for this commit - different from the one used in #5481 |
Fixes #5485
Summary
Migrated the following buttons and confirmation dialog in Channels > Edit channel details/New channel:
MessageDialogbyKModalVBtnwith the most suitableKButtonUnsaved changesdialogue box:(Before when using
MessageDialog)(After when using

KModal)