Skip to content

chore: prefer contrapose over contrapose!, when possible - #43999

Open
grunweg wants to merge 2 commits into
leanprover-community:masterfrom
grunweg:superfluous-pushneg
Open

grunweg wants to merge 2 commits into
leanprover-community:masterfrom
grunweg:superfluous-pushneg

Conversation

@grunweg

@grunweg grunweg commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

In ~50 cases in mathlib, the additional push Not step was not necessary at all. Found by the linter in #37907.


Open in Gitpod

In ~50 cases in mathlib, the additional push Not step was not necessary at all.
Found by the linter in leanprover-community#37907.
@github-actions

github-actions Bot commented Sep 20, 2026

Copy link
Copy Markdown

PR summary dc74f668c9

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit dc74f66).

  • +0 new declarations
  • −1 removed declarations
-MeasureTheory.AEFinStronglyMeasurable.mk.congr_simp

No changes to strong technical debt.
No changes to weak technical debt.

Current commit dc74f668c9
Reference commit b1007d8abf

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.py pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant