Skip to content

feat(by_contra,contrapose): warn if the push_neg step does nothing - #37907

Open
grunweg wants to merge 27 commits into
leanprover-community:masterfrom
grunweg:pushneg-warn
Open

grunweg wants to merge 27 commits into
leanprover-community:masterfrom
grunweg:pushneg-warn

Conversation

@grunweg grunweg added t-meta Tactics, attributes or user commands awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. labels Apr 10, 2026
@github-actions

github-actions Bot commented Apr 10, 2026

Copy link
Copy Markdown

PR summary 246f1e82ea

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean -- pending)

Computed after the build finishes.


No changes to strong technical debt.
No changes to weak technical debt.

Current commit 246f1e82ea
Reference commit b1007d8abf

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.py pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib-dependent-issues mathlib-dependent-issues Bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Apr 10, 2026
grunweg added a commit to grunweg/mathlib4 that referenced this pull request Apr 10, 2026
grunweg added a commit to grunweg/mathlib4 that referenced this pull request Apr 10, 2026
grunweg added a commit to grunweg/mathlib4 that referenced this pull request Apr 11, 2026
@mathlib-merge-conflicts mathlib-merge-conflicts Bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Apr 13, 2026
@mathlib-merge-conflicts

Copy link
Copy Markdown

This pull request has conflicts, please merge master and resolve them.

mathlib-bors Bot pushed a commit that referenced this pull request Apr 14, 2026
@github-actions github-actions Bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Apr 14, 2026
@mathlib-dependent-issues mathlib-dependent-issues Bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Apr 15, 2026
@grunweg

grunweg commented Apr 17, 2026

Copy link
Copy Markdown
Contributor Author

The remaining two warnings on the archive are false positives...

jessealama pushed a commit to jessealama/mathlib4 that referenced this pull request May 2, 2026
gaetanserre pushed a commit to gaetanserre/mathlib4 that referenced this pull request May 5, 2026
gasparattila pushed a commit to gasparattila/mathlib4 that referenced this pull request May 9, 2026
@mathlib-merge-conflicts mathlib-merge-conflicts Bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label May 26, 2026
@mathlib-merge-conflicts

Copy link
Copy Markdown

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions Bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Sep 20, 2026
@mathlib-dependent-issues mathlib-dependent-issues Bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Sep 20, 2026
Comment thread Mathlib/Tactic/ByContra.lean Outdated
Comment thread Mathlib/Tactic/ByContra.lean Outdated
Comment thread Mathlib/Tactic/ByContra.lean Outdated
grunweg and others added 2 commits September 21, 2026 11:59
Co-authored-by: Snir Broshi <26556598+SnirBroshi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) t-meta Tactics, attributes or user commands

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants