Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(component): Revised component library to use tsup instead #174

Closed
wants to merge 5 commits into from

Conversation

nebula-aac
Copy link
Contributor

This PR is related to #173 which there were issues with using the @types/mui-datatables and mui-datatables being exported correctly.

Revised the export to just do the mui-datatables instead, and call as normal. Any revision will need to be a custom component taking from the library itself.

Opening this PR to test changes in the GitHub Actions as for some reason my local dev storybook building was hanging and nothing happened.

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Antonette Caldwell <[email protected]>
Signed-off-by: Antonette Caldwell <[email protected]>
@nebula-aac nebula-aac changed the title fix(component): Revised component library to use tsup instead fix(component): Revised component library to use tsup instead Oct 18, 2023
@sudhanshutech
Copy link
Member

Is it ready to go @nebula-aac ?

@aabidsofi19
Copy link
Contributor

why did we change to tsup from vite ?

@nebula-aac
Copy link
Contributor Author

nebula-aac commented Oct 24, 2023

I'm testing to see what is causing the issues with the build from vite specifically and compare this with tsup.

Vite previously in its build, was not correctly rolling up the packages that I want to be external to not be included as a dependency or dev dependency, which prompted this PR.

Previously, in the earlier version 0.6.0, I created a test repo to check why the MUI data tables wasn't been exported correctly, and in the midst of testing, the Storybook also wasn't not building correctly through the GitHub Actions pipeline.

I release a beta to test this PR, and changed the exports because Storybook is complaining about the exports are mixed up.

I'm still testing though, sorry for the wait.

@nebula-aac
Copy link
Contributor Author

May not need this now, closing PR

@nebula-aac nebula-aac closed this Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants