Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Correct components and svg components #181

Merged
merged 8 commits into from
Oct 30, 2023

Conversation

nebula-aac
Copy link
Contributor

Notes for Reviewers

This PR is related to #180

  • Correct the Tooltip import path
  • Correct the imports calling @layer5/sistent-components and import internally in the sistent-components
  • Correct imports to call @layer5/sistent-svg instead of calling the relative paths.
  • There is no FormControlLabel component, there is one now
  • There's also no MenuItem component, there is one now also
  • Export CloseIcon and SearchIcon in svg

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Antonette Caldwell <[email protected]>
Signed-off-by: Antonette Caldwell <[email protected]>
Signed-off-by: Antonette Caldwell <[email protected]>
Signed-off-by: Antonette Caldwell <[email protected]>
@github-actions github-actions bot added area/ci Continuous integration | Build and release component/components component/icons labels Oct 30, 2023
Signed-off-by: Antonette Caldwell <[email protected]>
@nebula-aac nebula-aac added pr/do-not-merge PRs not ready to be merged priority/high High priority issue labels Oct 30, 2023
@nebula-aac
Copy link
Contributor Author

I'll finish the rest of this in the morning as I need to make sure everything is getting exported correctly in components.

@leecalcote
Copy link
Member

Copy link
Contributor

@aabidsofi19 aabidsofi19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great .

@aabidsofi19
Copy link
Contributor

@nebula-aac has that build bug now solved in this pr .

@sudhanshutech
Copy link
Member

@nebula-aac has that build bug now solved in this pr .

i guess that will solved here: #174

@leecalcote leecalcote merged commit 97b43a7 into layer5io:master Oct 30, 2023
5 of 8 checks passed
@github-actions github-actions bot removed the area/ci Continuous integration | Build and release label Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants