Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX- Dropdown in Navbar Not Visible on Hover #308 #315

Merged
merged 3 commits into from
Aug 28, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions assets/scss/_navbar_project.scss
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,14 @@
.current {
color: $primary !important;
}

&:hover {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
&:hover {
@media (min-width: 768px) {
&:hover {
.dropdown-menu {
display: block;
}
.dropdown-menu {
transform: translate(-15%, 0rem) !important;
}
}
}

.dropdown-menu {
display: block;
}
}
.dropdown-menu {
padding: 0;
transform: translate(-15%, 2.5rem) !important;
transform: translate(-15%, 0rem) !important;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
transform: translate(-15%, 0rem) !important;
transform: translate(-15%, 2.5rem) !important;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're having to use !important, then we're probably not affecting this change in the most appropriate area/class/style. Can we hunt down the original/root style controlling this element?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leecalcote I noticed that the !important wasn't originally necessary, and upon further testing, the dropdown behavior is functioning correctly without it. It seems someone might have added it mistakenly. Hence, we can proceed without using !important at all.

border-radius: 0;
.dropdown-item {
height: 5rem;
Expand Down
Loading