FIX- Dropdown in Navbar Not Visible on Hover #308 #315
Conversation
Signed-off-by: 2003Aditya <[email protected]>
✅ Deploy Preview for bejewelled-pegasus-b0ce81 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
LGTM!! |
| @@ -9,10 +9,14 @@ | |||
| .current { | |||
| color: $primary !important; | |||
| } | |||
|
|
|||
| &:hover { | |||
There was a problem hiding this comment.
| &:hover { | |
| @media (min-width: 768px) { | |
| &:hover { | |
| .dropdown-menu { | |
| display: block; | |
| } | |
| .dropdown-menu { | |
| transform: translate(-15%, 0rem) !important; | |
| } | |
| } | |
| } |
assets/scss/_navbar_project.scss
Outdated
| .dropdown-menu { | ||
| padding: 0; | ||
| transform: translate(-15%, 2.5rem) !important; | ||
| transform: translate(-15%, 0rem) !important; |
There was a problem hiding this comment.
| transform: translate(-15%, 0rem) !important; | |
| transform: translate(-15%, 2.5rem) !important; |
There was a problem hiding this comment.
If we're having to use !important, then we're probably not affecting this change in the most appropriate area/class/style. Can we hunt down the original/root style controlling this element?
There was a problem hiding this comment.
@leecalcote I noticed that the !important wasn't originally necessary, and upon further testing, the dropdown behavior is functioning correctly without it. It seems someone might have added it mistakenly. Hence, we can proceed without using !important at all.
Signed-off-by: 2003Aditya <[email protected]>
Signed-off-by: 2003Aditya <[email protected]>
Ashparshp
requested review from
iArchitSharma
and removed request for
iArchitSharma
|
@2003Aditya |
|
@vishalvivekm I'm sorry I couldn't join at that time.. |
|
@iArchitSharma able to review? |
|
Looks good to me! |
|
@2003Aditya Thank you for your contribution. Let's discuss it in today's website meeting. Adding this as an agenda item in meeting minutes |
|
@2003Aditya Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes. Any luck? |
|
@hargunkaur286, ready to merge? |
Notes for Reviewers
This PR fixes #308
Signed commits