Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #278 Unable to scroll through left sidebar #281

Merged
merged 18 commits into from
Jun 21, 2024
Merged

fix #278 Unable to scroll through left sidebar #281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
2c17bd6
fixed sidenav
preyanshu Jun 18, 2024
598d981
Merge branch 'master' of https://github.com/preyanshu/docs
preyanshu Jun 18, 2024
cf65fef
fix navbar
preyanshu Jun 18, 2024
a0fc6f7
Merge branch 'master' of https://github.com/preyanshu/docs
preyanshu Jun 18, 2024
cf3ed56
fix margin
preyanshu Jun 18, 2024
482f844
Merge branch 'master' of https://github.com/preyanshu/docs
preyanshu Jun 18, 2024
67a8fb4
Merge branch 'master' of https://github.com/preyanshu/docs
preyanshu Jun 18, 2024
b1f7efa
Merge branch 'master' of https://github.com/preyanshu/docs
preyanshu Jun 18, 2024
2434ea5
another margin fix
preyanshu Jun 18, 2024
432482a
fix : moblie view + horzontal scrollbar + hidden edges
preyanshu Jun 19, 2024
0e7fe4c
fix : moblie view + horzontal scrollbar + hidden edges
preyanshu Jun 19, 2024
bdf3355
fix height bug
preyanshu Jun 19, 2024
f53b3ac
Merge branch 'master' of https://github.com/preyanshu/docs
preyanshu Jun 19, 2024
4ad2f57
fix body overflow
preyanshu Jun 19, 2024
c33f8e9
another fix
preyanshu Jun 19, 2024
774f18f
another mobile view bug fix
preyanshu Jun 19, 2024
2aa5c07
mobie view
preyanshu Jun 19, 2024
d839f2c
Merge branch 'master' into master
iArchitSharma Jun 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions assets/scss/_pageinfo.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
margin: 2rem auto;
padding: 1.5rem;
padding-bottom: 0.5rem;


@each $color, $value in $theme-colors {
&-#{$color} {
Expand Down
28 changes: 14 additions & 14 deletions assets/scss/_sidebar-tree.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@
margin-right: -15px;
margin-left: -15px;

@include media-breakpoint-up(md) {
@supports (position: sticky) {
max-height: $_max-height;
overflow-y: auto;
}
}
// @include media-breakpoint-up(md) {
// @supports (position: sticky) {
// max-height: $_max-height;
// overflow-y: auto;
// }
// }

// Adjust height and padding when sidebar_search_disable is true, but only for
// >= `lg` views, because on tablet (`md`) and mobile (<= `sm`), the search
Expand Down Expand Up @@ -140,14 +140,14 @@
&__inner {
order: 0;

@include media-breakpoint-up(md) {
@supports (position: sticky) {
position: sticky;
top: 4rem;
z-index: 10;
height: calc(100vh - 5rem);
}
}
// @include media-breakpoint-up(md) {
// @supports (position: sticky) {
// position: sticky;
// top: 4rem;
// z-index: 10;
// height: calc(100vh - 5rem);
// }
// }

@include media-breakpoint-up(xl) {
flex: 0 1 320px;
Expand Down
45 changes: 34 additions & 11 deletions assets/scss/_styles_project.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,16 @@
// min-height: 90vh;

// }

//main sections
.td-outer {
margin-top: 3rem;
}

body{
overflow-x: hidden;
}

Comment on lines +69 to +72
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiding the helm table contents because of this css. Unable to scroll through the whole table contents.
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iArchitSharma I'll submit a fix for this in a while.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GaganpreetKaurKalsi thanks for pointing it out and yes please

// Main Middle Body
.td-content {
h2 {
Expand Down Expand Up @@ -191,16 +197,33 @@ a:not([href]):not([class]):hover {
z-index: 5;
}
.td-sidebar {
background-image: linear-gradient(
to top,
#1e2117,
#1d1912,
#18120e,
#0f0a09,
#000000
);
background-image: linear-gradient(to top, #1e2117, #1d1912, #18120e, #0f0a09, #000000);
position: sticky;
height: calc(100vh - 5.5rem);
top: 5.5rem;
overflow-y: auto;
padding-top: 1rem;
overflow-x: hidden;
}

@media screen and (max-width: 768px){
.td-sidebar {
position: relative;
height: auto;
top: 0;
padding-top: 0;
}

}
@media screen and (min-height: 800px) and (min-width: 768px) {
.td-sidebar {
height: 100vh;
top: 0;
padding-top: 3rem;
}
}


// Left sidebar
.td-sidebar-nav {
overflow: hidden;
Expand Down Expand Up @@ -275,9 +298,9 @@ a:not([href]):not([class]):hover {
);
@supports (position: sticky) {
position: sticky;
top: 4rem;
padding-top: 3rem;
height: calc(100vh - 4rem);
top: 5.5rem;
padding-top: 1rem;
height: calc(100vh - 5.5rem);
overflow-y: auto;
}
.taxo-categories {
Expand Down
Loading