Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #278 Unable to scroll through left sidebar #281

Merged
merged 18 commits into from
Jun 21, 2024

Conversation

preyanshu
Copy link
Contributor

Notes for Reviewers

This PR fixes #278

Signed commits

  • Yes, I signed my commits.

Copy link

netlify bot commented Jun 18, 2024

Deploy Preview for bejewelled-pegasus-b0ce81 ready!

Name Link
🔨 Latest commit d839f2c
🔍 Latest deploy log https://app.netlify.com/sites/bejewelled-pegasus-b0ce81/deploys/66750722bddcdd00084d1adb
😎 Deploy Preview https://deploy-preview-281--bejewelled-pegasus-b0ce81.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@Ashparshp Ashparshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Copy link
Contributor

@iArchitSharma iArchitSharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@preyanshu, first of all, thank you so much for this. However, your changes introduced a bug in the mobile view. Please fix it!
image

@preyanshu
Copy link
Contributor Author

preyanshu commented Jun 19, 2024

@preyanshu, first of all, thank you so much for this. However, your changes introduced a bug in the mobile view. Please fix it! image

yaaa i,ll check whats wrong , ig i commented out a imp. media query

@Ashparshp
Copy link
Contributor

@iArchitSharma Apologies for missing that!! @preyanshu, please fix it!!

Copy link
Contributor

@GaganpreetKaurKalsi GaganpreetKaurKalsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @preyanshu, could you fix the bottom scrollbar issue as well in this PR which was mentioned in the issue. Minor layout fix.

image

Also the scrollbar edges are getting hidden when at the extreme corners. Could you take a look at that?
image

@preyanshu
Copy link
Contributor Author

Hey @preyanshu, could you fix the bottom scrollbar issue as well in this PR which was mentioned in the issue. Minor layout fix.

image

Also the scrollbar edges are getting hidden when at the extreme corners. Could you take a look at that? image

so expected behaviour is that there should be no bottom scrolling bar?

@GaganpreetKaurKalsi
Copy link
Contributor

GaganpreetKaurKalsi commented Jun 19, 2024

Hey @preyanshu, could you fix the bottom scrollbar issue as well in this PR which was mentioned in the issue. Minor layout fix.
image
Also the scrollbar edges are getting hidden when at the extreme corners. Could you take a look at that? image

so expected behaviour is that there should be no bottom scrolling bar?

Yes, since the content won't be overflowing on the x-axis. There is some element on page which is overflowing out of the viewport

@preyanshu
Copy link
Contributor Author

hey guys @iArchitSharma @Ashparshp @GaganpreetKaurKalsi can u check this if its okkay?

Copy link
Contributor

@iArchitSharma iArchitSharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM now

@iArchitSharma iArchitSharma merged commit 53370d4 into layer5io:master Jun 21, 2024
5 of 6 checks passed
Comment on lines +69 to +72
body{
overflow-x: hidden;
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiding the helm table contents because of this css. Unable to scroll through the whole table contents.
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iArchitSharma I'll submit a fix for this in a while.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GaganpreetKaurKalsi thanks for pointing it out and yes please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Unable to scroll through left sidebar
4 participants