-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #278 Unable to scroll through left sidebar #281
Conversation
Signed-off-by: Preyanshu <[email protected]>
Signed-off-by: Preyanshu <[email protected]>
✅ Deploy Preview for bejewelled-pegasus-b0ce81 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Preyanshu <[email protected]>
Signed-off-by: Preyanshu <[email protected]>
Signed-off-by: Preyanshu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@preyanshu, first of all, thank you so much for this. However, your changes introduced a bug in the mobile view. Please fix it!
yaaa i,ll check whats wrong , ig i commented out a imp. media query |
@iArchitSharma Apologies for missing that!! @preyanshu, please fix it!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @preyanshu, could you fix the bottom scrollbar issue as well in this PR which was mentioned in the issue. Minor layout fix.
Also the scrollbar edges are getting hidden when at the extreme corners. Could you take a look at that?
so expected behaviour is that there should be no bottom scrolling bar? |
Yes, since the content won't be overflowing on the x-axis. There is some element on page which is overflowing out of the viewport |
Signed-off-by: Preyanshu <[email protected]>
Signed-off-by: Preyanshu <[email protected]>
Signed-off-by: Preyanshu <[email protected]>
Signed-off-by: Preyanshu <[email protected]>
Signed-off-by: Preyanshu <[email protected]>
Signed-off-by: Preyanshu <[email protected]>
Signed-off-by: Preyanshu <[email protected]>
Signed-off-by: Preyanshu <[email protected]>
hey guys @iArchitSharma @Ashparshp @GaganpreetKaurKalsi can u check this if its okkay? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks LGTM now
body{ | ||
overflow-x: hidden; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iArchitSharma I'll submit a fix for this in a while.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GaganpreetKaurKalsi thanks for pointing it out and yes please
Notes for Reviewers
This PR fixes #278
Signed commits