#923 fix for IndexOutOfBoundsException #41
Conversation
IndexOutOfBoundsException execption is fixed. Add validation to ensure embeddings list is not empty. changes: -- added a check for an empty "embeddings" -- Throws RuntimeException if the embeddings list empty
|
Hi @thrkrdk, thank you! When does this situation happen? Could you please add some test(s) to ensure the bug is fixed? Thanks! |
| @@ -197,6 +197,10 @@ private static float[] meanPool(float[][] vectors) { | |||
| } | |||
|
|
|||
| private float[] weightedAverage(List<float[]> embeddings, List<Integer> weights) { | |||
| if (embeddings.isEmpty()) { | |||
| throw new RuntimeException("Embeddings list cannot be empty"); | |||
There was a problem hiding this comment.
May I suggest using more specific IllegalArgumentException?
| @@ -197,6 +197,10 @@ private static float[] meanPool(float[][] vectors) { | |||
| } | |||
|
|
|||
| private float[] weightedAverage(List<float[]> embeddings, List<Integer> weights) { | |||
| if (embeddings.isEmpty()) { | |||
| throw new RuntimeException("Embeddings list cannot be empty"); | |||
There was a problem hiding this comment.
| throw new RuntimeException("Embeddings list cannot be empty"); | |
| throw new IllegalArgumentException("Embeddings list cannot be empty"); |
|
Hey guys! The last couple of days I was tinkering around with LLM stuff and followed some examples from a Java magazine and ended up with the same error while trying to embed a PDF file. I uploaded my code to Github: https://github.com/sebastianbogner/llm-test You can reproduce it by running Chroma via the docker-compose file and then just run the main method in HelloChroma.java. I'm not sure if the suggested fix will really solve the problem. Shouldn't the method weightedAverage() just return an empty float array as suggested in this PR? Regards |
#923 - IndexOutOfBoundsException execption is fixed. Add validation to ensure embeddings list is not empty. changes:
-- added a check for an empty "embeddings"
-- Throws RuntimeException if the embeddings list empty