-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Calendarの内部処理を整理する #5346
Open
AtsushiM
wants to merge
50
commits into
master
Choose a base branch
from
chore-refactoring-Calendar
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+379
−221
Open
Changes from all commits
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
3218dc1
chore: Calendar/YearPickerのthisYear,yearArray変数の生成をmemo化
AtsushiM e275b9e
chore: Calendar/YearPickerのyearArrayの生成ロジックを最適化
AtsushiM df5c1f0
chore: Calendar/YearPickerのonClickYearをuseCallbackする
AtsushiM c439a55
chore: Calendar/YearPickerのstyle生成ロジックを調整
AtsushiM b635bd9
chore: Calendar/YearPicker/YearButtonをmemo化
AtsushiM f0b9692
chore: CalendarのonSelectYearに関する処理を最適化
AtsushiM 2b8330e
Merge branch 'master' of https://github.com/kufu/smarthr-ui into chor…
AtsushiM 25dc445
chore: CalendarTableのstyle生成を適切にmemo化
AtsushiM f37cecd
chore: CalendarTableのdateCell styleをあらかじめ生成しきっておく方法に修正
AtsushiM c16beff
chore: CalendarTableのcurrentDayをmemo化
AtsushiM 28abeb3
chore: CalendarTableのnowの計算を必要になるまで実行しないように修正
AtsushiM caeb14f
chore: CalendarTableのfromDate,toDateをmemo化
AtsushiM a5c66eb
chore: CalendarTableのmonthsをmemo化
AtsushiM 9a81dd4
chore: CalendarTableのisSelectedDateの生成を最適化
AtsushiM 11bd9b7
chore: CalendarTableのisOutRange. isSelectedDateの生成を最適化
AtsushiM 260edfa
chore: CalendarTableのtdレンダリング判定を整理
AtsushiM ee3a967
chore: CalendarTableのcompareDay, compareDateの概念を整理
AtsushiM e48fe85
chore: CalendarTableのonClick内のdisabled判定は無駄なので削除
AtsushiM 1e2b234
chore: CalendarTableのSelectButtonTdを切り出す
AtsushiM a94ea9f
chore: CalendarTableのtarget.day, target.dateをmemo化
AtsushiM 67fd615
chore: CalendarTable/SelectButtonTdのdisabledの生成をmemo化
AtsushiM 8bb5131
chore: CalendarTable/SelectButtonTdのariaPressedの生成をmemo化
AtsushiM ac721b9
chore: CalendarTable/SelectButtonTdのdataIsTodayの生成をmemo化
AtsushiM b2c0c6e
chore: CalendarTable/SelectButtonTdのonClickの生成をmemo化
AtsushiM f9be950
chore: CalendarTable/SelectButtonTd/SelectButtonTdDateCellを切り出す
AtsushiM 8e30ef4
chore: CalendarTable/NullTdを切り出す
AtsushiM 384b570
chore: CalendarTable/MemoizedTheadを切り出す
AtsushiM c8dfab7
chore: calendarHelperのgetMonthArray内のdayjs生成を整理
AtsushiM 03dbfbf
chore: calendarHelperのgetMonthArray内のループをforに変更
AtsushiM c8af16d
chore: Calendarのstyles生成ロジックを整理
AtsushiM 1a13320
chore: Calendarのfroms変数の生成ロジックを整理
AtsushiM 8379269
chore: CalendarのcurrentMonth生成ロジックを整理
AtsushiM 803a08d
chore: CalendarのisValidValueをmemo化
AtsushiM b2f9e8c
chore: CalendarのdirectionMonthをmemo化
AtsushiM 07bd687
chore: CalendarのcalculatedCurrentMonthを定義
AtsushiM 60c0402
chore: CalendarのonClickMonthPrev,onClickMonthNextをmemo化
AtsushiM 21f2921
chore: CalendarのonClickSelectYearをmemo化
AtsushiM b12214e
chore: CalendarのMonthDirectionClusterを切り出す
AtsushiM e33e11b
chore: CalendarのMonthDirectionClusterを切り出す
AtsushiM 3aab919
chore: CalendarのYearSelectButtonを切り出す
AtsushiM 058d87b
chore: CalendarのYearSelectButtonを切り出す
AtsushiM 46cea3f
chore: Calendar内にHeadingが存在しないため、Sectionでのマークアップを辞める
AtsushiM b05fa3d
chore: fix ci
AtsushiM 6d711ba
chore: CalendarのselectedDayStrの精製方法を整理
AtsushiM 6cc7932
chore: CalendarTableのcurrentに関する処理を最適化
AtsushiM 177113b
chore: CalendarTableのfrom, toに関する処理を最適化
AtsushiM 1c2384a
chore: CalendarTableのcurrentに対する処理を整理
AtsushiM 5a054a4
chore: Calendarをリファクタリング
AtsushiM b1d5e31
chore: style -> className
AtsushiM 96410ea
Merge branch 'master' of https://github.com/kufu/smarthr-ui into chor…
AtsushiM File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from, to はほぼ固定で変わる可能性は低いため、memo化しています
またこれらをベースに計算される値も同様です