Skip to content

kubernetes-public: Fix workload identity binding #2951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2021

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Oct 15, 2021

Related:

Ensure service account tf-monitoring-deployer can be used in build cluster prow-build-trusted

Signed-off-by: Arnaud Meukam [email protected]

Related:
  - Part of: kubernetes#2588
  - Fixes: kubernetes#2942
  - followup of: kubernetes#2898

Ensure service account tf-monitoring-deployer can be used in build cluster prow-build-trusted

Signed-off-by: Arnaud Meukam <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 15, 2021
@ameukam ameukam changed the title kubernetes: Fix workload identity binding kubernetes-public: Fix workload identity binding Oct 15, 2021
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 15, 2021
@k8s-ci-robot k8s-ci-robot added area/infra Infrastructure management, infrastructure design, code in infra/ approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Oct 15, 2021
@ameukam
Copy link
Member Author

ameukam commented Oct 15, 2021

cc @dims @spiffxp

@spiffxp
Copy link
Member

spiffxp commented Oct 15, 2021

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit efcae30 into kubernetes:main Oct 15, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Oct 15, 2021
@ameukam
Copy link
Member Author

ameukam commented Oct 15, 2021

Ran ensure-main-project.sh:

    Updated IAM policy for serviceAccount [[email protected]].
    @@ -1,2 +1,4 @@
    +- member: serviceAccount:k8s-infra-prow-build-trusted.svc.id.goog[test-pods/tf-monitoring-deployer]
    +  role: roles/iam.workloadIdentityUser
     - member: serviceAccount:kubernetes-public.svc.id.goog[test-pods/tf-monitoring-deployer]
       role: roles/iam.workloadIdentityUser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/bash Bash scripts, testing them, writing less of them, code in infra/gcp/ area/infra Infrastructure management, infrastructure design, code in infra/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

audit followup: fix workload identity binding for tf-monitoring-deployer
3 participants