audit: update as of 2021-10-18 #2948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
area/audit
k8s-infra-ci-robot
force-pushed
the
autoaudit-prow
branch
from
5ec0a88 to
13b75da
Compare
k8s-infra-ci-robot
changed the title
k8s-infra-ci-robot
force-pushed
the
autoaudit-prow
branch
4 times, most recently
from
251ac01 to
2fde29c
Compare
k8s-infra-ci-robot
changed the title
k8s-infra-ci-robot
force-pushed
the
autoaudit-prow
branch
2 times, most recently
from
13fd66a to
99e6960
Compare
k8s-ci-robot
added
size/S
k8s-infra-ci-robot
force-pushed
the
autoaudit-prow
branch
3 times, most recently
from
433a565 to
fa1bd69
Compare
k8s-infra-ci-robot
force-pushed
the
autoaudit-prow
branch
from
fa1bd69 to
5bbe17e
Compare
k8s-ci-robot
added
size/M
spiffxp
approved these changes
Oct 19, 2021
| @@ -2,6 +2,7 @@ | |||
| "bindings": [ | |||
| { | |||
| "members": [ | |||
| "serviceAccount:k8s-infra-prow-build-trusted.svc.id.goog[test-pods/tf-monitoring-deployer]", | |||
There was a problem hiding this comment.
This is #2951
We should probably remove the kubernetes-public binding?
There was a problem hiding this comment.
$ gcloud iam service-accounts remove-iam-policy-binding --member "serviceAccount:kubernetes-public.svc.id.goog[test-pods/tf-monitoring-deployer]" --role "roles/iam.workloadIdentityUser" [email protected] --project=kubernetes-public
Updated IAM policy for serviceAccount [[email protected]].
bindings:
- members:
- serviceAccount:k8s-infra-prow-build-trusted.svc.id.goog[test-pods/tf-monitoring-deployer]
role: roles/iam.workloadIdentityUser
etag: BwXOt-ipjeQ=
version: 1
| @@ -2,7 +2,7 @@ | |||
| "bindings": [ | |||
| { | |||
| "members": [ | |||
| "user:[email protected]" | |||
| "group:[email protected]" | |||
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: k8s-infra-ci-robot, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Audit Updates sig-k8s-infra