-
Notifications
You must be signed in to change notification settings - Fork 45
feat: Implement Training Options pattern for flexible TrainJob customization #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement Training Options pattern for flexible TrainJob customization #91
Conversation
67d12d8 to
b39b364
Compare
2d7a8e6 to
dbba135
Compare
36c0160 to
95155f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @abhijeet-dhumal
I believe we need to handle how options will be applied for while backends. either we ignore options for localprocess or make options targeted towards specific backend.
f092845 to
03994e7
Compare
Pull Request Test Coverage Report for Build 19096824715Details
💛 - Coveralls |
7e16a13 to
b796722
Compare
…h podTemplateOverrides Signed-off-by: Abhijeet Dhumal <[email protected]>
b796722 to
dc0fb12
Compare
|
Thanks @abhijeet-dhumal for this outstanding contribution (and your patience 😅)! /lgtm /assign @andreyvelich @kramaranya |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this amazing work, @abhijeet-dhumal! 🎉
/lgtm
Also, we just beat the record for the most commented PR :)
|
Thank you for this amazing contribution @abhijeet-dhumal! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks @andreyvelich @astefanutti @kramaranya , delighted to have made this contribution. Thank you to all reviewers for their help. |
What this PR does / why we need it:
Fixes #87, #92, #116
QuickStart :
Common Options:
Kubernetes Options
Basic config:
Custom container specific options:
Pod customisation :
Creating custom options:
Overrides:
PodTemplateOverride Fields
PodSpecOverride Fields
ContainerOverride Fields
Checklist: