Skip to content

Improve accessibility for icon-only SVG buttons #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
komalharshita merged 3 commits into from
May 24, 2026
Merged

Improve accessibility for icon-only SVG buttons #153

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c85285
Improve accessibility for icon-only SVG buttons
jaygaikar-09 May 16, 2026
f38a1ce
Merge branch 'main' into fix-svg-accessibility
jaygaikar-09 May 17, 2026
a864cd3
Merge branch 'main' into fix-svg-accessibility
jaygaikar-09 May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 37 additions & 38 deletions templates/project.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,18 +67,18 @@ <h1 class="detail-title">{{ project.title }}</h1>

<!-- Quick-action buttons in the hero -->
<div class="detail-hero-actions">
<a href="/project/{{ project.id }}/download" class="btn-download">
<svg width="16" height="16" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2.5"
stroke-linecap="round" stroke-linejoin="round">
<a href="/project/{{ project.id }}/download" class="btn-download" aria-label="Download starter code file">
<svg aria-hidden="true" width="16" height="16" viewBox="0 0 24 24" fill="none" stroke="currentColor"
stroke-width="2.5" stroke-linecap="round" stroke-linejoin="round">
<path d="M21 15v4a2 2 0 0 1-2 2H5a2 2 0 0 1-2-2v-4" />
<polyline points="7 10 12 15 17 10" />
<line x1="12" y1="15" x2="12" y2="3" />
</svg>
Download Starter Code
</a>
<button class="btn-view-code" id="btn-view-code">
<svg width="16" height="16" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2.5"
stroke-linecap="round" stroke-linejoin="round">
<button class="btn-view-code" id="btn-view-code" aria-label="Open inline code viewer">
<svg aria-hidden="true" width="16" height="16" viewBox="0 0 24 24" fill="none" stroke="currentColor"
stroke-width="2.5" stroke-linecap="round" stroke-linejoin="round">
<polyline points="16 18 22 12 16 6" />
<polyline points="8 6 2 12 8 18" />
</svg>
Expand All @@ -103,11 +103,10 @@ <h1 class="detail-title">{{ project.title }}</h1>
<section class="detail-section">
<div class="detail-section-header">
<div class="detail-section-icon">
<svg width="18" height="18" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2"
stroke-linecap="round" stroke-linejoin="round">
<svg aria-hidden="true" width="18" height="18" viewBox="0 0 24 24" fill="none" stroke="currentColor"
stroke-width="2" stroke-linecap="round" stroke-linejoin="round">
<polyline points="9 11 12 14 22 4" />
<path d="M21 12v7a2 2 0 0 1-2 2H5a2 2 0 0 1-2-2V5a2 2 0 0 1 2-2h11" />
</polyline>
</svg>
</div>
<h2>Features</h2>
Expand All @@ -116,8 +115,8 @@ <h2>Features</h2>
{% for feature in project.features %}
<li class="feature-list-item">
<span class="feature-check">
<svg width="13" height="13" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="3"
stroke-linecap="round" stroke-linejoin="round">
<svg aria-hidden="true" width="13" height="13" viewBox="0 0 24 24" fill="none" stroke="currentColor"
stroke-width="3" stroke-linecap="round" stroke-linejoin="round">
<polyline points="20 6 9 17 4 12" />
</svg>
</span>
Expand All @@ -131,8 +130,8 @@ <h2>Features</h2>
<section class="detail-section">
<div class="detail-section-header">
<div class="detail-section-icon">
<svg width="18" height="18" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2"
stroke-linecap="round" stroke-linejoin="round">
<svg aria-hidden="true" width="18" height="18" viewBox="0 0 24 24" fill="none" stroke="currentColor"
stroke-width="2" stroke-linecap="round" stroke-linejoin="round">
<polyline points="22 12 18 12 15 21 9 3 6 12 2 12" />
</svg>
</div>
Expand Down Expand Up @@ -163,8 +162,8 @@ <h2>Project Roadmap</h2>
<section class="detail-section">
<div class="detail-section-header">
<div class="detail-section-icon">
<svg width="18" height="18" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2"
stroke-linecap="round" stroke-linejoin="round">
<svg aria-hidden="true" width="18" height="18" viewBox="0 0 24 24" fill="none" stroke="currentColor"
stroke-width="2" stroke-linecap="round" stroke-linejoin="round">
<path d="M18 13v6a2 2 0 0 1-2 2H5a2 2 0 0 1-2-2V8a2 2 0 0 1 2-2h6" />
<polyline points="15 3 21 3 21 9" />
<line x1="10" y1="14" x2="21" y2="3" />
Expand All @@ -178,15 +177,15 @@ <h2>Learning Resources</h2>
<!-- Parse the "Label: URL" format stored in the data -->
{% set parts = resource.split(": http") %}
{% if parts|length > 1 %}
<a href="http{{ parts[1] }}" target="_blank" rel="noopener noreferrer" class="resource-link">
<span>{{ parts[0] }}</span>
<svg width="12" height="12" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2.5"
stroke-linecap="round" stroke-linejoin="round">
<path d="M18 13v6a2 2 0 0 1-2 2H5a2 2 0 0 1-2-2V8a2 2 0 0 1 2-2h6" />
<polyline points="15 3 21 3 21 9" />
<line x1="10" y1="14" x2="21" y2="3" />
</svg>
</a>
<a href="http{{ parts[1] }}" target="_blank" rel="noopener noreferrer" class="resource-link">
<span>{{ parts[0] }}</span>
<svg aria-hidden="true" width="12" height="12" viewBox="0 0 24 24" fill="none" stroke="currentColor"
stroke-width="2.5" stroke-linecap="round" stroke-linejoin="round">
<path d="M18 13v6a2 2 0 0 1-2 2H5a2 2 0 0 1-2-2V8a2 2 0 0 1 2-2h6" />
<polyline points="15 3 21 3 21 9" />
<line x1="10" y1="14" x2="21" y2="3" />
</svg>
</a>
{% else %}
<span class="resource-plain">{{ resource }}</span>
{% endif %}
Expand All @@ -203,8 +202,8 @@ <h2>Learning Resources</h2>
<!-- Tech Stack card -->
<div class="sidebar-card">
<h3 class="sidebar-card-title">
<svg width="15" height="15" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2.5"
stroke-linecap="round" stroke-linejoin="round">
<svg aria-hidden="true" width="15" height="15" viewBox="0 0 24 24" fill="none" stroke="currentColor"
stroke-width="2.5" stroke-linecap="round" stroke-linejoin="round">
<rect x="2" y="3" width="20" height="14" rx="2" ry="2" />
<line x1="8" y1="21" x2="16" y2="21" />
<line x1="12" y1="17" x2="12" y2="21" />
Expand All @@ -221,8 +220,8 @@ <h3 class="sidebar-card-title">
<!-- Project stats card -->
<div class="sidebar-card">
<h3 class="sidebar-card-title">
<svg width="15" height="15" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2.5"
stroke-linecap="round" stroke-linejoin="round">
<svg aria-hidden="true" width="15" height="15" viewBox="0 0 24 24" fill="none" stroke="currentColor"
stroke-width="2.5" stroke-linecap="round" stroke-linejoin="round">
<circle cx="12" cy="12" r="10" />
<polyline points="12 6 12 12 16 14" />
</svg>
Expand Down Expand Up @@ -251,8 +250,8 @@ <h3 class="sidebar-card-title">
<!-- Starter code actions card -->
<div class="sidebar-card sidebar-card--code">
<h3 class="sidebar-card-title">
<svg width="15" height="15" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2.5"
stroke-linecap="round" stroke-linejoin="round">
<svg aria-hidden="true" width="15" height="15" viewBox="0 0 24 24" fill="none" stroke="currentColor"
stroke-width="2.5" stroke-linecap="round" stroke-linejoin="round">
<polyline points="16 18 22 12 16 6" />
<polyline points="8 6 2 12 8 18" />
</svg>
Expand All @@ -276,8 +275,8 @@ <h3 class="sidebar-card-title">
<div class="code-panel" id="code-panel">
<div class="code-panel-header">
<div class="code-panel-title">
<svg width="16" height="16" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2"
stroke-linecap="round" stroke-linejoin="round">
<svg aria-hidden="true" width="16" height="16" viewBox="0 0 24 24" fill="none" stroke="currentColor"
stroke-width="2" stroke-linecap="round" stroke-linejoin="round">
<polyline points="16 18 22 12 16 6" />
<polyline points="8 6 2 12 8 18" />
</svg>
Expand All @@ -286,13 +285,13 @@ <h3 class="sidebar-card-title">
<div class="code-panel-actions">
<a href="/project/{{ project.id }}/download" class="code-panel-download">Download file</a>
<button class="btn-copy-code" id="btn-copy-code" aria-label="Copy code to clipboard">
<svg class="copy-icon" width="14" height="14" viewBox="0 0 24 24" fill="none" stroke="currentColor"
stroke-width="2.5" stroke-linecap="round" stroke-linejoin="round">
<svg class="copy-icon" aria-hidden="true" width="14" height="14" viewBox="0 0 24 24" fill="none"
stroke="currentColor" stroke-width="2.5" stroke-linecap="round" stroke-linejoin="round">
<rect x="9" y="9" width="13" height="13" rx="2" ry="2" />
<path d="M5 15H4a2 2 0 0 1-2-2V4a2 2 0 0 1 2-2h9a2 2 0 0 1 2 2v1" />
</svg>
<svg class="check-icon" width="14" height="14" viewBox="0 0 24 24" fill="none" stroke="currentColor"
stroke-width="2.5" stroke-linecap="round" stroke-linejoin="round" style="display:none">
<svg class="check-icon" aria-hidden="true" width="14" height="14" viewBox="0 0 24 24" fill="none"
stroke="currentColor" stroke-width="2.5" stroke-linecap="round" stroke-linejoin="round" style="display:none">
<polyline points="20 6 9 17 4 12" />
</svg>
<span class="copy-btn-label">Copy Code</span>
Expand All @@ -308,8 +307,8 @@ <h3 class="sidebar-card-title">

<!-- Copy success toast notification -->
<div class="copy-toast" id="copy-toast" role="status" aria-live="polite">
<svg width="15" height="15" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2.5"
stroke-linecap="round" stroke-linejoin="round">
<svg aria-hidden="true" width="15" height="15" viewBox="0 0 24 24" fill="none" stroke="currentColor"
stroke-width="2.5" stroke-linecap="round" stroke-linejoin="round">
<polyline points="20 6 9 17 4 12" />
</svg>
Copied to clipboard!
Expand Down
Loading