Improve accessibility for icon-only SVG buttons - #153
Conversation
|
@jaygaikar-09 is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@jaygaikar-09 resolve the merge conflicts |
|
@komalharshita Done!! |
|
@jaygaikar-09 please check again |
|
@komalharshita Now everything looks fine ig |
komalharshita
left a comment
There was a problem hiding this comment.
Good accessibility-focused contribution overall. The PR correctly improves accessibility for icon-only interactive elements by adding meaningful aria-label attributes and appropriately marking decorative SVGs with aria-hidden="true".
The implementation is well scoped, avoids unrelated UI/CSS changes, and follows established accessibility best practices without affecting existing functionality or layout behavior.
I also verified that the changes are semantic-only, which keeps regression risk low while meaningfully improving screen-reader compatibility and assistive technology support.
Minor future enhancement ideas could include tooltip/focus-visible consistency for icon-only actions, but the current implementation is solid and merge-ready.
Approved for merge.
Summary [required]
Improved accessibility for icon-only interactive elements by adding appropriate ARIA attributes in
templates/project.htmlandtemplates/index.html.Decorative SVG icons now include
aria-hidden="true"so screen readers ignore non-informative visual elements. Additionally, icon-only buttons and links now have meaningfularia-labelattributes to provide accessible descriptions for assistive technologies.These changes improve screen reader compatibility without affecting the visual UI, styling, or existing functionality.
Related Issue [required]
Closes #86
Type of Change [required]
data/projects.jsonWhat Was Changed [required]
templates/project.htmlaria-labelattributes to icon-only buttons and linkstemplates/project.htmlaria-hidden="true"to decorative SVG iconstemplates/index.htmlaria-hidden="true"to decorative SVG iconsHow to Test This PR [required]