-
Notifications
You must be signed in to change notification settings - Fork 15
Bump dependencies and require Node.js 6 #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
package.json
Outdated
| { | ||
| "name": "bin-build", | ||
| "version": "3.0.0", | ||
| "version": "3.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shouldn't touch this; it's the maintainer's job/choice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let alone, this should be a major bump due to the node.js version requirement bump.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for the advice. I have reverted that updated, and rebased.
|
Ping @kevva |
…he tunnel-agent package downstream. See https://nodesecurity.io/advisories/598 . Note: xo 0.21 requires Node 6+ , so we drop support for Node 4 because the new download package doesn't even support it, and add support for Node 10
|
Download v7.1.0 https://github.com/kevva/download/releases/tag/v7.1.0 got released, maybe you should update the dependencies accordingly? |
|
Ping @kevva :-) |
|
Ping @kevva |
|
Any plan to release this ? Looking at the |
|
@kevva @sindresorhus could you release the new version with this change? ideally #17 as well. |
|
Hi team, |
Bump download dependency in order to address vulnerability found in the tunnel-agent package downstream. See https://nodesecurity.io/advisories/598
Unfortunately, the
downloadpackage decided to drop support for Node 4 as well. Considering the state of where we are in the evolution of Node, we might as well drop it here too and enable support for Node 10.I also bumped the minor version of the package.