Update dependent module 'download' to more than 7 #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. Drop node v4 support since xojs/xo drop it 3. Prevent xojs/xo library from updating to major vesion 4. Modify bin-build version with minor version upgrade
Contributor
|
Notice, I already submitted the same fix here days ago: #14 |
|
This is a duplicate of #14 and should be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Thanks for your contribution!
When I tried 'npm install' (actually installing laravel-mix dependent libraries) under the proxy, 'MaxRedirectsError' occurred at the part accessing a resource via http instead of https. As I checked dependent library 'download' commit history, it's already merged as follows https://github.com/kevva/download/pull/158, but was with major version upgrade.
I would like you to migrate this change into this module, and keep the version '3.x.x'!!
Hopefully this propose is merged and if you have anything to me, please let me know.
Thank you,