Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open this awesome project up for Linux users #5

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Open this awesome project up for Linux users #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
14a98c4
Add option to use local install of osslsigncode
payne8 Sep 13, 2016
c3d58ac
make sure options is available to function getting path
payne8 Sep 13, 2016
7830db8
run `osslsigncode` if command is found
payne8 Sep 13, 2016
c67f294
Merge branch 'master' into master
payne8 Apr 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
[![npm](https://img.shields.io/npm/v/signcode.svg)](https://www.npmjs.com/packages/signcode)
[![downloads](https://img.shields.io/npm/dm/signcode.svg)](https://www.npmjs.com/packages/signcode)

Sign Windows executables and installers from a Mac.
Sign Windows executables and installers from a Mac or a machine with osslsigncode installed.

Works with `.pem`, `.p12`, and `.pfx` code signing files.

Expand Down Expand Up @@ -59,6 +59,7 @@ signcode.verify({ path: '/Users/kevin/apps/myapp.exe' }, function (error) {
| `password` | `String` | No | Password to the certificate or key. |
| `passwordPath` | `String` | No | Path to a file containing the password for the certificate or key. |
| `site` | `String` | No | Website URL to include in the signature. |
| `useLocal` | `Boolean` | No | `true` to use a locally installed version of osslsigncode (Linux anyone?). |

### Verification Options

Expand Down
18 changes: 14 additions & 4 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ function spawnSign (options, callback) {
spawnOptions.stdio = ['ignore', 'ignore', 'pipe']
}

var signcode = ChildProcess.spawn(getSigncodePath(), args, spawnOptions)
var signcode = ChildProcess.spawn(getSigncodePath(options), args, spawnOptions)

var stderr = ''
signcode.stderr.on('data', function (data) {
Expand Down Expand Up @@ -144,7 +144,7 @@ function spawnVerify (options, callback) {
)
}

var signcode = ChildProcess.spawn(getSigncodePath(), args)
var signcode = ChildProcess.spawn(getSigncodePath(options), args)

var stdout = ''
signcode.stdout.on('data', function (data) {
Expand Down Expand Up @@ -186,6 +186,16 @@ function getOutputPath (inputPath, hash) {
return path.join(path.dirname(inputPath), outputName)
}

function getSigncodePath () {
return path.join(__dirname, 'vendor', process.platform, 'osslsigncode')
function getSigncodePath (options) {
var signcodePath = path.join(__dirname, 'vendor', process.platform, 'osslsigncode')

if (options.useLocal) {
try {
ChildProcess.execSync('which osslsigncode')
signcodePath = 'osslsigncode'
} catch (e) {
console.warn('Could not find a local version of osslsigncode. Attempting to use the version packaged with signcode.')
}
}
return signcodePath
}