Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

Simulate txn #1281

Merged
merged 26 commits into from
Dec 14, 2023
Merged

Simulate txn #1281

merged 26 commits into from
Dec 14, 2023

Conversation

apoorvsadana
Copy link
Collaborator

@apoorvsadana apoorvsadana commented Nov 26, 2023 •
edited
Loading

Changes made

  1. Added simulate txn
  2. Updated starknet-rs libraries (just version change, no other changes were needed)
  3. Removed FeeConfig which allowed DisableTransactionFee access from state variable. Instead, added GetAppConfig which returns all state variables of the pallet.
  4. Fixed estimateFee not working for non zero max_fee

@apoorvsadana apoorvsadana marked this pull request as draft November 26, 2023 10:40
@Eikix Eikix mentioned this pull request Nov 27, 2023
Closed
tdelabro
tdelabro suggested changes Nov 29, 2023
View reviewed changes
crates/primitives/simulations/src/lib.rs Show resolved Hide resolved
crates/primitives/state/src/lib.rs Outdated Show resolved Hide resolved
crates/primitives/state/src/lib.rs Outdated Show resolved Hide resolved
crates/primitives/simulations/Cargo.toml Outdated Show resolved Hide resolved
crates/primitives/simulations/Cargo.toml Outdated Show resolved Hide resolved
crates/pallets/starknet/src/lib.rs Outdated Show resolved Hide resolved
crates/pallets/starknet/runtime_api/Cargo.toml Outdated Show resolved Hide resolved
crates/client/rpc/Cargo.toml Show resolved Hide resolved
crates/client/rpc-core/Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
@greged93 greged93 marked this pull request as ready for review December 7, 2023 16:40
tdelabro
tdelabro suggested changes Dec 8, 2023
View reviewed changes
crates/primitives/state/src/lib.rs Outdated Show resolved Hide resolved
crates/primitives/simulations/Cargo.toml Outdated Show resolved Hide resolved
crates/primitives/simulations/Cargo.toml Outdated Show resolved Hide resolved
crates/pallets/starknet/src/utils.rs Outdated Show resolved Hide resolved
tdelabro
tdelabro suggested changes Dec 11, 2023
View reviewed changes
crates/primitives/state/src/lib.rs Outdated Show resolved Hide resolved
crates/primitives/state/src/lib.rs Outdated Show resolved Hide resolved
crates/primitives/state/src/lib.rs Outdated Show resolved Hide resolved
crates/pallets/starknet/src/utils.rs Outdated Show resolved Hide resolved
crates/primitives/fee/src/lib.rs Outdated Show resolved Hide resolved
crates/pallets/starknet/src/blockifier_state_adapter.rs Outdated Show resolved Hide resolved
crates/pallets/starknet/src/lib.rs Outdated Show resolved Hide resolved
tdelabro
tdelabro suggested changes Dec 12, 2023
View reviewed changes
crates/pallets/starknet/src/execution_config.rs Outdated Show resolved Hide resolved
crates/pallets/starknet/src/blockifier_state_adapter.rs Outdated Show resolved Hide resolved
crates/pallets/starknet/src/lib.rs Outdated Show resolved Hide resolved
crates/pallets/starknet/src/lib.rs Outdated Show resolved Hide resolved
starknet-rpc-test/spec_version.rs Outdated Show resolved Hide resolved
@tdelabro tdelabro merged commit 36fe795 into keep-starknet-strange:main Dec 14, 2023
12 checks passed
@tdelabro tdelabro mentioned this pull request Dec 14, 2023
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@greged93 greged93 greged93 left review comments

@tdelabro tdelabro tdelabro approved these changes

@EvolveArt EvolveArt Awaiting requested review from EvolveArt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apoorvsadana @tdelabro @greged93