Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

feat(rpc): add starknet_simulateTransactions rpc #1152

Closed
tdelabro opened this issue Sep 28, 2023 · 6 comments
Closed

feat(rpc): add starknet_simulateTransactions rpc #1152

tdelabro opened this issue Sep 28, 2023 · 6 comments
Assignees
@lana-shanghai
Labels
backlog Ready to be picked enhancement New feature or request feature New feature rpc stale

Comments

@tdelabro
Copy link
Collaborator

Feature Request

What to do?

We should add support for the starknet_simulateTransactions rpc

How to do it?

@m-kus did most of the work in #883, but we delayed the merge due to #992
You should probably start from a fresh branch, since so much has changed, but the flow developed there can probably be kept.

Related code

The specs: https://github.com/starkware-libs/starknet-specs/blob/59b838cdcc7b1cbf92f4249b00927185c93628e9/api/starknet_trace_api_openrpc.json#L41
@tdelabro tdelabro added the enhancement New feature or request label Sep 28, 2023
@tdelabro tdelabro added this to Madara Sep 28, 2023
@tdelabro tdelabro added rpc feature New feature backlog Ready to be picked labels Sep 28, 2023
@tdelabro tdelabro moved this to 🔖 Ready in Madara Sep 28, 2023
@ayushtom
Copy link
Contributor

ayushtom commented Oct 3, 2023

I can pick this

@tdelabro tdelabro moved this from 🔖 Ready to 🏗 In progress in Madara Oct 4, 2023
@tdelabro
Copy link
Collaborator Author

Hey, All good?

@tdelabro
Copy link
Collaborator Author

👋

@ayushtom
Copy link
Contributor

Hi @tdelabro . I haven't been able to continue on this due to time constraints. You can unassign me from this issue.
Sorry for the delay from my end!

@tdelabro tdelabro moved this from 🏗 In progress to 🔖 Ready in Madara Oct 31, 2023
@lana-shanghai lana-shanghai self-assigned this Nov 4, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍
Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale label Dec 5, 2023
@tdelabro tdelabro moved this from 🔖 Ready to 🏗 In progress in Madara Dec 13, 2023
@tdelabro tdelabro moved this from 🏗 In progress to ✅ Done in Madara Dec 14, 2023
@tdelabro
Copy link
Collaborator Author

closed by #1281

@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lana-shanghai lana-shanghai

Labels
backlog Ready to be picked enhancement New feature or request feature New feature rpc stale
Projects
Madara
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lana-shanghai @tdelabro @ayushtom