Skip to content

Fix block verbosedata population… #2275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
someone235 merged 4 commits into from
Mar 18, 2025
Merged

Fix block verbosedata population… #2275

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cfed010
Fix block verbosedata population from skipping transaction verbosedat…
May 5, 2024
f8dec0e
Merge branch 'dev' into bug-block-verbosedata
michaelsutton May 9, 2024
c00b469
Update app/rpc/rpccontext/verbosedata.go
someone235 Mar 18, 2025
3ec0ee1
Merge branch 'dev' into bug-block-verbosedata
someone235 Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions app/rpc/rpccontext/verbosedata.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,10 +81,6 @@ func (ctx *Context) PopulateBlockWithVerboseData(block *appmessage.RPCBlock, dom
block.VerboseData.SelectedParentHash = blockInfo.SelectedParent.String()
}

if blockInfo.BlockStatus == externalapi.StatusHeaderOnly {
return nil
}

// Get the block if we didn't receive it previously
if domainBlock == nil {
domainBlock, err = ctx.Domain.Consensus().GetBlockEvenIfHeaderOnly(blockHash)
Expand All @@ -93,6 +89,10 @@ func (ctx *Context) PopulateBlockWithVerboseData(block *appmessage.RPCBlock, dom
}
}

if len(domainBlock.Transactions) == 0 {
return nil
}

transactionIDs := make([]string, len(domainBlock.Transactions))
for i, transaction := range domainBlock.Transactions {
transactionIDs[i] = consensushashing.TransactionID(transaction).String()
Expand Down
Loading