Fix block verbosedata population… #2275
Merged
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a population when BlockInfo errorenously reports block as Header only, but domainBlock is still fount with GetBlockEvenIfHeaderOnly.
|
We are currently running an archive node and need this fix badly - will this PR be incorporated into the next version anytime soon? |
|
I just noticed that this version of kaspad has been deprecated. We have confirmed that this is not an issue with the Rust version. |
someone235
requested changes
Feb 23, 2025
someone235
force-pushed
the
dev
branch
2 times, most recently
from
46111bb to
c23c1d1
Compare
someone235
force-pushed
the
bug-block-verbosedata
branch
from
dc8c832 to
3ec0ee1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix block verbosedata population from skipping transaction verbosedata population when BlockInfo errorenously reports block as Header only, but domainBlock is still fount with GetBlockEvenIfHeaderOnly.
Basically this affects archival servers. Once archival server moves on pruning point it loses verboseData from transactions as such transaction id is lost unless repopulated from the block data.