Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable perfsprint linter #5224

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Enable perfsprint linter #5224

wants to merge 2 commits into from
+310 −293

Commits on Nov 14, 2024

  1. Only add reset and status subcommands on Linux 

    They were erroring out on Windows, so remove the OS checks from the
commands and only add them on OSes on which they are supported.

Signed-off-by: Tom Wieczorek <[email protected]>
    @twz123
    twz123 committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    3f29a41 View commit details
    Browse the repository at this point in the history

  2. Enable perfsprint linter 

    ... and fix lints on the way.

Most of the fixes are straightforward replacements of fmt.Errorf with
errors.New and string concatenations instead of fmt.Sprintf with a
single leading or trailing %s. Single integer conversions have been
replaced with the corresponding functions from the strconv package. Used
path.Join, filepath.Join and url.URL where it made sense.

Signed-off-by: Tom Wieczorek <[email protected]>
    @twz123
    twz123 committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    0a294b8 View commit details
    Browse the repository at this point in the history