Enable perfsprint linter #5224
Draft
Enable perfsprint linter #5224
+311
−293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twz123
force-pushed
the
perfsprint
branch
2 times, most recently
from
090e08c
to
b5431ed
Compare
|
This pull request has merge conflicts that need to be resolved. |
|
This pull request has merge conflicts that need to be resolved. |
kke
reviewed
Nov 13, 2024
kke
reviewed
Nov 13, 2024
cmd/api/api.go
Outdated
Comment on lines
248
to
260
| sendError(errors.New("go away"), w, http.StatusUnauthorized) | ||
| return | ||
| } | ||
|
|
||
| parts := strings.Split(auth, "Bearer ") | ||
| if len(parts) == 2 { | ||
| token := parts[1] | ||
| if !c.isValidToken(r.Context(), token, usage) { | ||
| sendError(fmt.Errorf("go away"), w, http.StatusUnauthorized) | ||
| sendError(errors.New("go away"), w, http.StatusUnauthorized) | ||
| return | ||
| } | ||
| } else { | ||
| sendError(fmt.Errorf("go away"), w, http.StatusUnauthorized) | ||
| sendError(errors.New("go away"), w, http.StatusUnauthorized) |
There was a problem hiding this comment.
Maybe this go away error warrants a var ErrUnauthorized = errors.New("go away").
kke
reviewed
Nov 13, 2024
kke
reviewed
Nov 13, 2024
|
This pull request has merge conflicts that need to be resolved. |
|
This pull request has merge conflicts that need to be resolved. |
They were erroring out on Windows, so remove the OS checks from the commands and only add them on OSes on which they are supported. Signed-off-by: Tom Wieczorek <[email protected]>
... and fix lints on the way. Most of the fixes are straightforward replacements of fmt.Errorf with errors.New and string concatenations instead of fmt.Sprintf with a single leading or trailing %s. Single integer conversions have been replaced with the corresponding functions from the strconv package. Used path.Join, filepath.Join and url.URL where it made sense. Signed-off-by: Tom Wieczorek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
... and fix lints on the way.
Most of the fixes are straightforward replacements of
fmt.Errorfwitherrors.Newand string concatenations instead offmt.Sprintfwith a single leading or trailing%s. Single integer conversions have been replaced with the corresponding functions from thestrconvpackage. Usedpath.Join,filepath.Joinandurl.URLwhere it made sense.Only add reset and status subcommands on Linux. They were erroring out on Windows, so remove the OS checks from the
commands and only add them on OSes on which they are supported.
Type of change
How Has This Been Tested?
Checklist: